NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Notifier] Added possibility to extract path from provided DSN#34747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromespectrio:master

Feb 4, 2020

Merged

[Notifier] Added possibility to extract path from provided DSN#34747

fabpot merged 1 commit intosymfony:masterfromespectrio:master

Feb 4, 2020

Conversation

Copy link

Contributor

espectrio commentedDec 1, 2019

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix#34746
License	MIT

I'm currently working on Microsoft Teams Webhook Notifier (https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using#setting-up-a-custom-incoming-webhook), and there is no way to provide DSN for it, because of missing parse_url()['path'] option

It looks like
teams://outlook.office.com/webhook/{uuid}@{uuid}/IncomingWebhook/{id}/{uuid}
and I'd like to be able to build Notifier Transport endpoint from it

[Notifier] Added possibility to extract path from provided DSN

ab9b49b

carsonbot added Status: Needs Review Feature labels

Dec 1, 2019

nicolas-grekas added this to thenext milestone

Dec 2, 2019

fabpot added the Notifier label

Feb 4, 2020

fabpot approved these changes

Feb 4, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 4, 2020

Copy link

Member

fabpot commentedFeb 4, 2020

Thank you@espectrio.

fabpot added a commit that referenced this pull request

Feb 4, 2020

feature#34747[Notifier] Added possibility to extract path from prov…

753d4a2

…ided DSN (espectrio)This PR was merged into the 5.1-dev branch.Discussion----------[Notifier] Added possibility to extract path from provided DSN| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#34746| License       | MITI'm currently working on Microsoft Teams Webhook Notifier (https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using#setting-up-a-custom-incoming-webhook), and there is no way to provide DSN for it, because of missing parse_url()['path'] optionIt looks like`teams://outlook.office.com/webhook/{uuid}@{uuid}/IncomingWebhook/{id}/{uuid}`and I'd like to be able to build Notifier Transport endpoint from itCommits-------ab9b49b [Notifier] Added possibility to extract path from provided DSN