Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag#34732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
maxhelias commentedNov 30, 2019
You should target this on branch 4.4 |
ContributorAuthor
tienvx commentedNov 30, 2019
Fixed. Thank@maxhelias |
nicolas-grekas approved these changesNov 30, 2019
maxhelias approved these changesNov 30, 2019
fabpot approved these changesNov 30, 2019
Member
fabpot commentedNov 30, 2019
Thank you@tienvx. |
fabpot added a commit that referenced this pull requestNov 30, 2019
…allowed in 'bind' tag (tienvx)This PR was merged into the 4.4 branch.Discussion----------[DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag| Q | A| ------------- | ---| Branch? | 4.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | N/A <!-- prefix each issue number with "Fix #", if any -->| License | MIT| Doc PR |symfony/symfony-docs/pull/12741 <!-- required for new features -->Add test case forhttps://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services and fix a bug with attribute 'tag' is not allowedCommits-------e38f7d4 [DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestDec 2, 2019
This PR was merged into the 4.4 branch.Discussion----------[DependencyInjection] Bind tagged servicesUpdate documentation forhttps://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-servicesNOTE: this documentation requiresymfony/symfony#34732 to be mergedCommits-------7ec6d9d [DependencyInjection] Bind tagged services
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add test case forhttps://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services and fix a bug with attribute 'tag' is not allowed