NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Use UserInterface to @return in getUser method#34723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:3.4fromArman-Hosseini:patch-6

Dec 10, 2019

Merged

[FrameworkBundle] Use UserInterface to @return in getUser method#34723

nicolas-grekas merged 1 commit intosymfony:3.4fromArman-Hosseini:patch-6

Dec 10, 2019

Conversation

Copy link

Contributor

Arman-Hosseini commentedNov 29, 2019

Q	A
Branch?	3.4
Bug fix?	no
New feature?	no
Deprecations?	no
License	MIT

carsonbot added the Status: Needs Review label

Nov 29, 2019

xabbuh reviewed

Nov 30, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.phpShow resolvedHide resolved

xabbuh added FrameworkBundle Security labels

Nov 30, 2019

xabbuh reviewed

Nov 30, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.php OutdatedShow resolvedHide resolved

nicolas-grekas added this to the3.4 milestone

Nov 30, 2019

nicolas-grekas reviewed

Nov 30, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.php OutdatedShow resolvedHide resolved

Arman-Hosseini changed the title~~Use UserInterface to @return in getUser method~~[FrameworkBundle] Use UserInterface to @return in getUser method

Nov 30, 2019

ro0NL reviewed

Dec 1, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.phpShow resolvedHide resolved

darielopper approved these changes

Dec 2, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 2, 2019

nicolas-grekas approved these changes

Dec 3, 2019

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(the discussion is for an RFC maybe, but not for 3.4, so not a blocker)

xabbuh approved these changes

Dec 3, 2019

View reviewed changes

[FrameworkBundle] Use UserInterface to@returnin getUser method

9f1ebd7

Copy link

Member

nicolas-grekas commentedDec 10, 2019

Thank you@Arman-Hosseini.

nicolas-grekas added a commit that referenced this pull request

Dec 10, 2019

minor#34723[FrameworkBundle] Use UserInterface to@returnin getUse…

cd43346

…r method (Arman-Hosseini)This PR was squashed before being merged into the 3.4 branch.Discussion----------[FrameworkBundle] Use UserInterface to@return in getUser method| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| License       | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master.-->Commits-------9f1ebd7 [FrameworkBundle] Use UserInterface to@return in getUser method