Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Support typehint to deprecated FlattenException in controller#34662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromandrew-demb:patch-1
Nov 28, 2019

Conversation

@andrew-demb
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#34661
LicenseMIT
Doc PR

We should support converting throwable toFlattenException with typehint to deprecated class also

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Isn't the currentExceptionListener intended to preserve that compatibility?

Could you please elaborate a bit more on the actual use case?

@nicolas-grekasnicolas-grekas changed the titleFix #34661 Support typehint to deprecated FlattenException in controller[HttpKernel] Support typehint to deprecated FlattenException in controllerNov 28, 2019
@andrew-demb
Copy link
ContributorAuthor

andrew-demb commentedNov 28, 2019•
edited
Loading

My use case:
I replacedExceptionListener usage in favorErrorListener (as deprecation message describes) and I expect, that my (not updated - with used old-namespaced exception class in argument typehint) controller will work.

@nicolas-grekas
Copy link
Member

Thank you@andrew-demb.

nicolas-grekas added a commit that referenced this pull requestNov 28, 2019
…on in controller (andrew-demb)This PR was squashed before being merged into the 4.4 branch.Discussion----------[HttpKernel] Support typehint to deprecated FlattenException in controller| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#34661| License       | MIT| Doc PR        |We should support converting throwable to `FlattenException` with typehint to deprecated class alsoCommits-------26b4e37 [HttpKernel] Support typehint to deprecated FlattenException in controller
@nicolas-grekasnicolas-grekas merged commit26b4e37 intosymfony:4.4Nov 28, 2019
@andrew-dembandrew-demb deleted the patch-1 branchNovember 28, 2019 08:16
This was referencedDec 1, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto left review comments

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@andrew-demb@nicolas-grekas@yceruto@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp