Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Mailer] Allow to configure or disable the message bus to use#34648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromogizanagi:mailer/allow_configure_message_busNov 30, 2019
Merged
[Mailer] Allow to configure or disable the message bus to use#34648
fabpot merged 1 commit intosymfony:masterfromogizanagi:mailer/allow_configure_message_busNov 30, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
voodooism commentedNov 27, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It is a really nice approach! I mentioned the problem inthis issue |
fabpot approved these changesNov 30, 2019
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestNov 30, 2019
… to use (ogizanagi)This PR was merged into the 5.1-dev branch.Discussion----------[Mailer] Allow to configure or disable the message bus to use| Q | A| ------------- | ---| Branch? | master <!-- see below -->| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |#34633 <!-- prefix each issue number with "Fix #", if any -->| License | MIT| Doc PR | todoA new `mailer.message_bus` option allowing to choose the message bus to use instead of using the default one.Also allows to set it to `false` so no message bus is used and the transport will be called directly.Commits-------42fd0cf [Mailer] Allow to configure or disable the message bus to use
Merged
3 tasks
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestMar 11, 2021
…chard)This PR was squashed before being merged into the 5.2 branch.Discussion----------[Mailer] Configuration of the message_bus to use<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `5.x` for features of unreleased versions).-->Documentssymfony/symfony#34648Closes#12736Commits-------2d924e8 [Mailer] Configuration of the message_bus to use
fabpot added a commit that referenced this pull requestDec 11, 2022
…ble the message bus to use (jschaedl, fabpot)This PR was merged into the 6.3 branch.Discussion----------[FrameworkBundle][Notifier] Allow to configure or disable the message bus to use| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | tbd <!-- required for new features -->For the mailer integration there is already a possibility to disable or configure the `message_bus` to use. See:#34633 and#34648This PR introduces a similar config option `notifier.message_bus` for the notifier integration.Things done:- [x] Add a config option `notifier.message_bus` for the notifier configuration- [x] Adjust FrameworkExtension considering the new `message_bus` config option- [x] Add tests for the new config optionCommits-------fc7aaa6 Fix logic and tests215e802 Allow to configure or disable the message bus to use
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestDec 11, 2022
…ble the message bus to use (jschaedl, fabpot)This PR was merged into the 6.3 branch.Discussion----------[FrameworkBundle][Notifier] Allow to configure or disable the message bus to use| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | tbd <!-- required for new features -->For the mailer integration there is already a possibility to disable or configure the `message_bus` to use. See:symfony/symfony#34633 andsymfony/symfony#34648This PR introduces a similar config option `notifier.message_bus` for the notifier integration.Things done:- [x] Add a config option `notifier.message_bus` for the notifier configuration- [x] Adjust FrameworkExtension considering the new `message_bus` config option- [x] Add tests for the new config optionCommits-------fc7aaa6123 Fix logic and tests215e802741 Allow to configure or disable the message bus to use
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJul 28, 2023
…ble the message bus to use (jschaedl, fabpot)This PR was merged into the 6.3 branch.Discussion----------[FrameworkBundle][Notifier] Allow to configure or disable the message bus to use| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | tbd <!-- required for new features -->For the mailer integration there is already a possibility to disable or configure the `message_bus` to use. See:symfony/symfony#34633 andsymfony/symfony#34648This PR introduces a similar config option `notifier.message_bus` for the notifier integration.Things done:- [x] Add a config option `notifier.message_bus` for the notifier configuration- [x] Adjust FrameworkExtension considering the new `message_bus` config option- [x] Add tests for the new config optionCommits-------fc7aaa6123 Fix logic and tests215e802741 Allow to configure or disable the message bus to use
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
A new
mailer.message_busoption allowing to choose the message bus to use instead of using the default one.Also allows to set it to
falseso no message bus is used and the transport will be called directly.