Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] notice on potential undefined index#34636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.3fromsylvainmetayer:patch-1
Nov 28, 2019
Merged

[VarDumper] notice on potential undefined index#34636

nicolas-grekas merged 1 commit intosymfony:4.3fromsylvainmetayer:patch-1
Nov 28, 2019

Conversation

@sylvainmetayer
Copy link
Contributor

Fix the following issue that can happen (Drupal 8 project for context, with theTwig vardumper module) :

Notice: Undefined index: file in Symfony\Component\VarDumper\Dumper\ContextProvider\SourceContextProvider->getContext() (line 55 of /var/www/app/vendor/symfony/var-dumper/Dumper/ContextProvider/SourceContextProvider.php).
QA
Branch?4.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsNone
LicenseMIT
Doc PRN/A

@sylvainmetayersylvainmetayer changed the titlefix: notice on potential undefined indexfix(vardumper): notice on potential undefined indexNov 26, 2019
@stof
Copy link
Member

the question is how it is possible to have these non-existent keys in the output ofdebug_backtrace

ogizanagi reacted with thumbs up emoji

@ogizanagi
Copy link
Contributor

Also if it is possible, we should probably not just fallback to null here, it may have other impacts on this code path.

@nicolas-grekasnicolas-grekas added this to the4.3 milestoneNov 26, 2019
@nicolas-grekasnicolas-grekas changed the titlefix(vardumper): notice on potential undefined index[VarDumper] notice on potential undefined indexNov 26, 2019
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedNov 27, 2019•
edited
Loading

the question is how it is possible to have these non-existent keys in the output of debug_backtrace

it is, PHP inserts virtual frames in a few cases (can't remember exactly which ones)

@sylvainmetayer
Copy link
ContributorAuthor

I have been trying to reproduce the error today to provide more context but I haven't be able to reproduce it yet.

@nicolas-grekas
Copy link
Member

Thank you@sylvainmetayer.

nicolas-grekas added a commit that referenced this pull requestNov 28, 2019
…tayer)This PR was squashed before being merged into the 4.3 branch.Discussion----------[VarDumper] notice on potential undefined indexFix the following issue that can happen (Drupal 8 project for context, with the [Twig vardumper](https://www.drupal.org/project/twig_vardumper) module) :```Notice: Undefined index: file in Symfony\Component\VarDumper\Dumper\ContextProvider\SourceContextProvider->getContext() (line 55 of /var/www/app/vendor/symfony/var-dumper/Dumper/ContextProvider/SourceContextProvider.php).```| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | None| License       | MIT| Doc PR        | N/ACommits-------d4c34e0 [VarDumper] notice on potential undefined index
@nicolas-grekasnicolas-grekas merged commitd4c34e0 intosymfony:4.3Nov 28, 2019
This was referencedDec 1, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@sylvainmetayer@stof@ogizanagi@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp