NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Workflow] Added`Registry::has()` to check if a workflow exists#34591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lyrixx merged 1 commit intosymfony:masterfromlyrixx:workflow-registry-has

Nov 29, 2019

Merged

[Workflow] Added`Registry::has()` to check if a workflow exists#34591

lyrixx merged 1 commit intosymfony:masterfromlyrixx:workflow-registry-has

Nov 29, 2019

Conversation

Copy link

Member

lyrixx commentedNov 25, 2019•
edited
Loading

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix#34584
License	MIT
Doc PR

Allow to use

$registry->has($subject);// or$registry->has($subject,'workflow_a')

carsonbot added Status: Needs Review Workflow Feature labels

Nov 25, 2019

nicolas-grekas added this to thenext milestone

Nov 25, 2019

nicolas-grekas reviewed

Nov 25, 2019

View reviewed changes

src/Symfony/Component/Workflow/Registry.php OutdatedShow resolvedHide resolved

[Workflow] AddedRegistry::has() to check if a workflow exists

8a4f03d

lyrixx force-pushed theworkflow-registry-has branch from11866e1 to8a4f03dCompare

November 25, 2019 15:20

Copy link

Member

javiereguiluz commentedNov 27, 2019

@lyrixx thanks for this contribution. In order to make this ready to be documented, could you please add some little example to the pull request description. Also, please tell us if there are some things to keep in mind about this feature (e.g. edge cases where it doesn't work, etc.) Thanks!

Copy link

MemberAuthor

lyrixx commentedNov 27, 2019

@javiereguiluz I'm not sure it worth documenting it. This method is discoverable easily with autocomplete and It make what it is supposed to without edge case. Anyway I added a s mall example

lyrixx added a commit that referenced this pull request

Nov 29, 2019

feature#34591[Workflow] AddedRegistry::has()to check if a workf…

0a91f9b

…low exists (lyrixx)This PR was merged into the 5.1-dev branch.Discussion----------[Workflow] Added `Registry::has()` to check if a workflow exists| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |Fix#34584| License       | MIT| Doc PR        |---Allow to use```php$registry->has($subject);// or$registry->has($subject, 'workflow_a')```Commits-------8a4f03d [Workflow] Added `Registry::has()` to check if a workflow exists

lyrixx merged commit8a4f03d intosymfony:master

Nov 29, 2019

nicolas-grekas modified the milestones:next,5.1

May 4, 2020