Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Don't cache "not-fresh" state#34580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedNov 25, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#34567 |
| License | MIT |
| Doc PR | - |
Kocal commentedNov 25, 2019
It fixed the issue, thanks! |
ro0NL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same 👍
acasademont commentedNov 25, 2019
I'd appreciate 4.4.1 could be tagged as soon as this patch is merged 🙏 |
fabpot commentedNov 25, 2019
Thank you@nicolas-grekas. |
This PR was merged into the 4.4 branch.Discussion----------[HttpKernel] Don't cache "not-fresh" state| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#34567| License | MIT| Doc PR | -Commits-------be80db3 [HttpKernel] Don't cache "not-fresh" state
stof commentedNov 25, 2019
@nicolas-grekas shouldn't we also mark the cache as fresh after we rebuild it ? |
nicolas-grekas commentedNov 25, 2019
@stof I considered this but thought it was not needed - this would only save one extra freshness check - with little to no perf benefit. |