Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle][Cache] Don't deep-merge cache pools configuration#34577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromalxndrbauer:ticket_34488_no-deep-merge
Nov 25, 2019

Conversation

@alxndrbauer
Copy link
Contributor

@alxndrbaueralxndrbauer commentedNov 24, 2019•
edited by chalasr
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#34488
LicenseMIT

Prevents deep-merge of cache.pools.adapters configuration

@alxndrbaueralxndrbauerforce-pushed theticket_34488_no-deep-merge branch from2aece9f to66cea79CompareNovember 25, 2019 04:50
@alxndrbauer
Copy link
ContributorAuthor

Hmm sry didn't test it. Now one test is failing. I'll take a look later.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Failure unrelated.

@fabpotfabpotforce-pushed theticket_34488_no-deep-merge branch from66cea79 toa0d6d30CompareNovember 25, 2019 07:15
@fabpot
Copy link
Member

Thank you@alxndrbauer.

fabpot added a commit that referenced this pull requestNov 25, 2019
…iguration (alxndrbauer)This PR was squashed before being merged into the 4.4 branch (closes#34577).Discussion----------[FrameworkBundle][Cache] Don't deep-merge cache pools configuration| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#34488| License       | MITPrevents deep-merge of cache.pools configurationCommits-------a0d6d30 [FrameworkBundle][Cache] Don't deep-merge cache pools configuration
@fabpotfabpot merged commita0d6d30 intosymfony:4.4Nov 25, 2019
@chalasr
Copy link
Member

This should have been merged into master I think, we used to merge similar changes as features.
If we consider this a bugfix, then it applies to 3.4 as well.

@nicolas-grekas
Copy link
Member

Supporting several adapters is a new feature of 4.4. Thus 4.4 :)

chalasr reacted with thumbs up emoji

@chalasr
Copy link
Member

Indeed sorry , misled by the PR title which tells "pools"

@alxndrbaueralxndrbauer deleted the ticket_34488_no-deep-merge branchNovember 25, 2019 17:04
This was referencedDec 1, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@alxndrbauer@fabpot@chalasr@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp