Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Skip unknown method calls for factories in check types pass#34562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromfancyweb:di-fix-check-types-declaration-factory-caseNov 28, 2019
Merged
[DI] Skip unknown method calls for factories in check types pass#34562
nicolas-grekas merged 1 commit intosymfony:4.4fromfancyweb:di-fix-check-types-declaration-factory-caseNov 28, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
ro0NL commentedNov 24, 2019
For us this now gives the following error: which is excluded from PSR loading in services.yaml |
60a8bf1 to592bff8Comparenicolas-grekas approved these changesNov 28, 2019
Member
nicolas-grekas commentedNov 28, 2019
Thank you@fancyweb. |
nicolas-grekas added a commit that referenced this pull requestNov 28, 2019
…s pass (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[DI] Skip unknown method calls for factories in check types pass| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#34559| License | MIT| Doc PR | -Ref#30885 and#30889.Commits-------592bff8 [DI] Skip unknown method calls for factories in check types pass
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref#30885 and#30889.