Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config][ReflectionClassResource] Handle parameters with undefined constant as their default values#34560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromfancyweb:config-reflection-class-undef-constantNov 29, 2019
Merged
[Config][ReflectionClassResource] Handle parameters with undefined constant as their default values#34560
nicolas-grekas merged 1 commit intosymfony:3.4fromfancyweb:config-reflection-class-undef-constantNov 29, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6ec8085 to6ea7b07CompareMember
nicolas-grekas commentedNov 24, 2019
Some tests fail, but this looks promising! |
4dbcaa4 toab35a71CompareContributorAuthor
fancyweb commentedNov 29, 2019
I fixed the code for PHP <= 7.0. |
src/Symfony/Component/Config/Resource/ReflectionClassResource.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
13231fc tob955f83Compare…nstant as their default values
b955f83 to8de2a22Comparenicolas-grekas approved these changesNov 29, 2019
Member
nicolas-grekas commentedNov 29, 2019
Thank you@fancyweb. |
nicolas-grekas added a commit that referenced this pull requestNov 29, 2019
…ndefined constant as their default values (fancyweb)This PR was merged into the 3.4 branch.Discussion----------[Config][ReflectionClassResource] Handle parameters with undefined constant as their default values| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#34053| License | MIT| Doc PR | -Basically we can fix this bug by "reimplementing" php src way of building the __toString() of the method except that we avoid to call the undefined constant. Obviously we cannot invalidate the resource if the value of the constant changes since we never knew it. However, it's still better than now.Commits-------8de2a22 [Config][ReflectionClassResource] Handle parameters with undefined constant as their default values
This was referencedDec 1, 2019
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically we can fix this bug by "reimplementing" php src way of building the __toString() of the method except that we avoid to call the undefined constant. Obviously we cannot invalidate the resource if the value of the constant changes since we never knew it. However, it's still better than now.