Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fix autocomplete multibyte input support#34558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Member
nicolas-grekas commentedNov 28, 2019
Oh, and please add a test case if possible :) |
d67c7ea todffe932Comparedffe932 toa1129f9CompareContributorAuthor
fancyweb commentedNov 29, 2019
I used existing helper functions and added a test case. |
chalasr approved these changesNov 29, 2019
nicolas-grekas approved these changesNov 29, 2019
Member
nicolas-grekas commentedNov 29, 2019
Thank you@fancyweb. |
nicolas-grekas added a commit that referenced this pull requestNov 29, 2019
This PR was merged into the 3.4 branch.Discussion----------[Console] Fix autocomplete multibyte input support| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#34254| License | MIT| Doc PR | -Added it just where it's needed.Commits-------a1129f9 [Console] Fix autocomplete multibyte input support
This was referencedDec 1, 2019
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added it just where it's needed.