Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PropertyInfo] Add support for typed properties (PHP 7.4)#34557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromdunglas:typed-properties
Nov 25, 2019

Conversation

dunglas
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRn/a

Add support fortyped properties, a new feature introduced in PHP 7.4:

class Foo{publicBar$bar;private ?bool$nullableBoolProp;}$this->extractor->getTypes(Foo::class,'bar');// Type[]$this->extractor->getTypes(Foo::class,'nullableBoolProp');// Type[]

#SymfonyHackday

garak, vudaltsov, versh23, andreybolonin, and bigfoot90 reacted with thumbs up emojiazjezz, maks-rafalko, JrBour, DavidBadura, Koc, lyrixx, and andreybolonin reacted with hooray emojialanpoulain, DavidBadura, GregoireHebert, remy-theroux, Shine-neko, Taluu, andreybolonin, vudaltsov, and juuuuuu reacted with heart emoji
@nicolas-grekasnicolas-grekas added this to thenext milestoneNov 24, 2019
@fabpot
Copy link
Member

Thank you@dunglas.

@ro0NL
Copy link
Contributor

@fabpot@dunglas please consider for 4.4/5.0 :} while technically a new feature.. it's common to remove@var annotations when moving to php74 typed properties, if not the obvious thing to do.

However, doing so requires this PR for compatibility.. hence it's a bugfix IMHO.

versh23, jdreesen, ostrolucky, deguif, and lucascourot reacted with thumbs up emoji

@dunglas
Copy link
MemberAuthor

I'm not against backporting this to 4.4. I can take car of this. What do you think@fabpot@nicolas-grekas?

ogizanagi, jdreesen, and ndench reacted with thumbs up emoji

@chalasr
Copy link
Member

👍 for backporting.

@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
fabpot added a commit that referenced this pull requestAug 28, 2020
…7.4) (dunglas)This PR was merged into the 4.4 branch.Discussion----------[PropertyInfo] Backport support for typed properties (PHP 7.4)| Q             | A| ------------- | ---| Branch?       | 4.4 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | N/A. <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        |symfony/symfony-docs#13719 to be fixedBackports#34557 as suggested.One of my workmate hit this issue with the Serializer component and it was not obvious for him why it was not working, without hint.Commits-------1b19f25 [PropertyInfo] Backport support for typed properties (PHP 7.4)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@TaluuTaluuTaluu approved these changes

@lyrixxlyrixxlyrixx approved these changes

@Shine-nekoShine-nekoShine-neko approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

9 participants
@dunglas@fabpot@ro0NL@chalasr@Taluu@lyrixx@Shine-neko@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp