Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[PropertyInfo] Add support for typed properties (PHP 7.4)#34557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
lyrixx approved these changesNov 23, 2019
src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Shine-neko approved these changesNov 24, 2019
Taluu approved these changesNov 24, 2019
lyrixx approved these changesNov 25, 2019
fabpot approved these changesNov 25, 2019
Thank you@dunglas. |
I'm not against backporting this to 4.4. I can take car of this. What do you think@fabpot@nicolas-grekas? |
👍 for backporting. |
Merged
fabpot added a commit that referenced this pull requestAug 28, 2020
…7.4) (dunglas)This PR was merged into the 4.4 branch.Discussion----------[PropertyInfo] Backport support for typed properties (PHP 7.4)| Q | A| ------------- | ---| Branch? | 4.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | N/A. <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR |symfony/symfony-docs#13719 to be fixedBackports#34557 as suggested.One of my workmate hit this issue with the Serializer component and it was not obvious for him why it was not working, without hint.Commits-------1b19f25 [PropertyInfo] Backport support for typed properties (PHP 7.4)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support fortyped properties, a new feature introduced in PHP 7.4:
#SymfonyHackday