Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Slack bridge tests#34549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.0fromJeroeny:slack-tests
Nov 30, 2019
Merged

Conversation

@Jeroeny
Copy link
Contributor

@JeroenyJeroeny commentedNov 23, 2019•
edited
Loading

QA
Branch?5.0
Bug fix?no
New feature?no
Deprecations?no
TicketsSee#33687
LicenseMIT

Adds tests for the Slack bridge of the Notifier component.

#SymfonyHackday

@JeroenyJeroeny changed the titleadd Notifier Slack bridge tests[Notifier] Add Slack bridge testsNov 23, 2019
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me. I've made some minor comments about CS.

@fabpot
Copy link
Member

Thank you@Jeroeny.

fabpot added a commit that referenced this pull requestNov 30, 2019
This PR was squashed before being merged into the 5.0 branch (closes#34549).Discussion----------[Notifier] Add Slack bridge tests| Q             | A| ------------- | ---| Branch?       | 5.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | See#33687| License       | MITAdds tests for the Slack bridge of the Notifier component.#SymfonyHackdayCommits-------626fdaa [Notifier] Add Slack bridge tests
@fabpotfabpot merged commit626fdaa intosymfony:5.0Nov 30, 2019
@JeroenyJeroeny deleted the slack-tests branchDecember 2, 2019 08:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Jeroeny@fabpot@OskarStark@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp