Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Add DateTimeZoneNormalizer into Dependency Injection#34546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromjewome62:add-normalizer-to-DI
Nov 24, 2019

Conversation

@jewome62
Copy link
Contributor

@jewome62jewome62 commentedNov 23, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
Deprecations?no
Ticketsnone
LicenseMIT
Doc PRnone

#30915
I have forgot to add new Normalizer into DI 🤭

#SymfonyHackday

@jewome62jewome62 changed the titleAdd DateTimeZoneNormalizer into Dependency Injection[Serializer] Add DateTimeZoneNormalizer into Dependency InjectionNov 23, 2019
@jewome62
Copy link
ContributorAuthor

Appveyor CI fail is not related to this PR

@nicolas-grekas
Copy link
Member

Shouldn't this target 4.4?

@xabbuh
Copy link
Member

If we treat this as a bugfix, it must be merged into the4.3 branch where theDateTimeZoneNormalizer was added.

@nicolas-grekasnicolas-grekas added this to the4.3 milestoneNov 24, 2019
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

4.3 LGTM

@fabpot
Copy link
Member

Thank you@jewome62.

fabpot added a commit that referenced this pull requestNov 24, 2019
…jection (jewome62)This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes#34546).Discussion----------[Serializer] Add DateTimeZoneNormalizer into Dependency Injection| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | none| License       | MIT| Doc PR        | none#30915I have forgot to add new Normalizer into DI 🤭#SymfonyHackdayCommits-------1a81dd7 Add DateTimeZoneNormalizer into Dependency Injection
@fabpotfabpot merged commit1a81dd7 intosymfony:4.3Nov 24, 2019
@jewome62jewome62 deleted the add-normalizer-to-DI branchNovember 25, 2019 11:50
This was referencedDec 1, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@jewome62@nicolas-grekas@xabbuh@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp