NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Monolog Bridge] Fixed accessing static property as non static.#34533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromSander-Toonen:bugfix-34505

Nov 24, 2019

Merged

[Monolog Bridge] Fixed accessing static property as non static.#34533

fabpot merged 1 commit intosymfony:3.4fromSander-Toonen:bugfix-34505

Nov 24, 2019

Conversation

Copy link

Contributor

Sander-Toonen commentedNov 22, 2019

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#34505
License	MIT
Doc PR	N/A

Sander-Toonen requested a review fromsroze as acode owner

November 22, 2019 21:54

carsonbot added Status: Needs Review Bug labels

Nov 22, 2019

Sander-Toonen changed the base branch frommaster to4.4

November 22, 2019 21:57

Sander-Toonen changed the title~~Bugfix 34505~~[Monolog Bridge] Fixed accessing static property as non static.

Nov 22, 2019

chalasr added this to the4.4 milestone

Nov 23, 2019

fancyweb approved these changes

Nov 23, 2019

•

edited

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 23, 2019

xabbuh requested changes

Nov 23, 2019

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The commit that changed the property tostatic (Seldaek/monolog@e0d18f4) was first released in Monolog 1.4.0. I think we should bump the requirement formonolog/monolog incomposer.json accordingly.

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Nov 23, 2019

Copy link

ContributorAuthor

Sander-Toonen commentedNov 23, 2019•
edited
Loading

Isn't the requirement forsymfony/monolog-bridge already greater than 1.4.0?

4.4 requires ^1.25.1, 4.3 and 3.4 require ~1.19.

xabbuh approved these changes

Nov 23, 2019

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, that was my mistake. I misread1.4.0 as 1.40`.

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Nov 23, 2019

xabbuh approved these changes

Nov 23, 2019

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, that was my mistake. I misread1.4.0 as 1.40`.

fabpot approved these changes

Nov 24, 2019

View reviewed changes

Copy link

Member

fabpot commentedNov 24, 2019

So, this one should be merged in 3.4, right?

[Monolog Bridge] Fixed accessing static property as non static.

aa045d1

fabpot force-pushed thebugfix-34505 branch from42100f1 toaa045d1Compare

November 24, 2019 18:38

fabpot changed the base branch from4.4 to3.4

November 24, 2019 18:38

Copy link

Member

fabpot commentedNov 24, 2019

Thank you@Sander-Toonen.

fabpot added a commit that referenced this pull request

Nov 24, 2019

bug#34533[Monolog Bridge] Fixed accessing static property as non st…

3bd5fae

…atic. (Sander-Toonen)This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead (closes#34533).Discussion----------[Monolog Bridge] Fixed accessing static property as non static.| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  |  no| Deprecations? | no| Tickets       |Fix#34505| License       | MIT| Doc PR        | N/ACommits-------aa045d1 [Monolog Bridge] Fixed accessing static property as non static.