NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] drop return type declaration#34516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4fromxabbuh:issue-34508

Nov 22, 2019

Merged

[HttpKernel] drop return type declaration#34516

fabpot merged 1 commit intosymfony:4.4fromxabbuh:issue-34508

Nov 22, 2019

Conversation

Copy link

Member

xabbuh commentedNov 22, 2019

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#34508
License	MIT
Doc PR

The configured memory limit can exceed the range that can be represented
by an integer.

drop return type declaration

9368502

The configured memory limit can exceed the range that can be representedby an integer.

xabbuh added this to the4.4 milestone

Nov 22, 2019

carsonbot added Status: Needs Review HttpKernel Bug labels

Nov 22, 2019

xabbuh mentioned this pull request

Nov 22, 2019

Return value of Symfony\Component\HttpKernel\DataCollector\MemoryDataCollector::convertToBytes() must be of the type int, float returned#34508

Closed

fancyweb approved these changes

Nov 22, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 22, 2019

chalasr approved these changes

Nov 22, 2019

View reviewed changes

yceruto approved these changes

Nov 22, 2019

View reviewed changes

fabpot approved these changes

Nov 22, 2019

View reviewed changes

Copy link

Member

fabpot commentedNov 22, 2019

Thank you@xabbuh.

fabpot added a commit that referenced this pull request

Nov 22, 2019

bug#34516[HttpKernel] drop return type declaration (xabbuh)

a8a9e69

This PR was merged into the 4.4 branch.Discussion----------[HttpKernel] drop return type declaration| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#34508| License       | MIT| Doc PR        |The configured memory limit can exceed the range that can be representedby an integer.Commits-------9368502 drop return type declaration

fabpot merged commit9368502 intosymfony:4.4

Nov 22, 2019

Copy link

tony5Dim commentedNov 22, 2019•
edited
Loading

Will this be commited for v5.0 also ?

Copy link

MemberAuthor

xabbuh commentedNov 22, 2019

Yes, we merge branches up regularly.

xabbuh deleted the issue-34508 branch

November 22, 2019 14:52

This was referencedDec 1, 2019

Release v4.4.1#34742

Merged

Release v5.0.1#34743

Merged

LukeTowers mentioned this pull request

Dec 17, 2020

File upload error in build 469octobercms/october#5410

Closed

LukeTowers mentioned this pull request

Dec 27, 2020

[HttpFoundation] Drop int return type from parseFilesize()#39633

Merged

nicolas-grekas added a commit that referenced this pull request

Jan 19, 2021

bug#39633[HttpFoundation] Drop int return type from parseFilesize()…

3257d4c

… (LukeTowers)This PR was merged into the 4.4 branch.Discussion----------[HttpFoundation] Drop int return type from parseFilesize()| Q             | A| ------------- | ---| Branch?       | 4.4 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | Fix [octobercms/october#5410](octobercms/october#5410)| License       | MIT| Doc PR        |Related:#34516,#34508,9368502,octobercms/october#5410Commits-------a1b31f8 [HttpFoundation] Drop int return type from parseFilesize()