Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] ConstraintValidatorTestCase: add missing return value to mocked validate method calls#34458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
chalasr merged 1 commit intosymfony:3.4fromogizanagi:validator_test_case_mock_return_valueNov 23, 2019
Merged
[Validator] ConstraintValidatorTestCase: add missing return value to mocked validate method calls#34458
chalasr merged 1 commit intosymfony:3.4fromogizanagi:validator_test_case_mock_return_valueNov 23, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…mocked validate method calls
chalasr approved these changesNov 20, 2019
stof approved these changesNov 20, 2019
xabbuh approved these changesNov 21, 2019
Member
chalasr commentedNov 23, 2019
Thank you@ogizanagi. |
chalasr pushed a commit that referenced this pull requestNov 23, 2019
…n value to mocked validate method calls (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[Validator] ConstraintValidatorTestCase: add missing return value to mocked validate method calls| Q | A| ------------- | ---| Branch? | 3.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | N/A <!-- prefix each issue number with "Fix #", if any -->| License | MIT| Doc PR | N/ASpotted while working on#34456.Not sure it should really qualify as a bugfix, but the `ContextualValidatorInterface::validate` method is expected to return the instance. If [chaining in a validator](https://github.com/symfony/symfony/pull/34456/files#diff-0e6e3106aa637d750d47e86a14cef8d4R43), trying to use this test methods would throw an error, trying to call a method on `null`.Commits-------8d1f326 [Validator] ConstraintValidatorTestCase: add missing return value to mocked validate method calls
This was referencedDec 1, 2019
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Spotted while working on#34456.
Not sure it should really qualify as a bugfix, but the
ContextualValidatorInterface::validatemethod is expected to return the instance. Ifchaining in a validator, trying to use this test methods would throw an error, trying to call a method onnull.