Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form][ButtonBuilder] Prevent buttons names from starting with a capital letter#34445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fancyweb
Copy link
Contributor

@fancywebfancyweb commentedNov 18, 2019•
edited
Loading

QA
Branch?5.0
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Ping@xabbuh.
It was forbidden in#28969 but it does not throw in 5.0 as it should.
We cannot useFormConfigBuilder::validateName() inButtonBuilder because this one allows first capital letters. We cannot change it because form names can start with capital letters (it is currently not deprecated in 4.4).
So we either also deprecate this (but why?) or we just validate button names in its own builder (proposed change in this PR).

@fancywebfancywebforce-pushed theform-forbid-first-capital-letter branch 2 times, most recently from8855026 tofe82230CompareNovember 18, 2019 21:50
@fancywebfancywebforce-pushed theform-forbid-first-capital-letter branch fromfe82230 to5c843ffCompareNovember 18, 2019 21:57
@fancyweb
Copy link
ContributorAuthor

Actually it was missing in#31705

@fancywebfancywebforce-pushed theform-forbid-first-capital-letter branch from8676a9d to0eab1fdCompareNovember 18, 2019 23:05
@xabbuh
Copy link
Member

Looking back in the history of changes it seems to me that was a mistake in#28969 to deprecate names starting with uppercase letters.

GPHemsley reacted with thumbs up emoji

@fancyweb
Copy link
ContributorAuthor

fancyweb commentedNov 19, 2019•
edited
Loading

Not too late to remove this deprecation (as a bugfix I guess) and close this PR, isn'it? Better than continuing in error 😄

Just saw#34448. Closing here then 😄

@fancywebfancyweb deleted the form-forbid-first-capital-letter branchNovember 19, 2019 08:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

1 more reviewer

@darielopperdarielopperdarielopper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fancyweb@xabbuh@darielopper@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp