Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Redis Tag Aware warn on wrong eviction policy#34403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromandrerom:redisTagAware_warn_on_wrong_eviction_policyNov 16, 2019
Merged
[Cache] Redis Tag Aware warn on wrong eviction policy#34403
nicolas-grekas merged 1 commit intosymfony:4.4fromandrerom:redisTagAware_warn_on_wrong_eviction_policyNov 16, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 task
09972f9 to304ea8dComparenicolas-grekas approved these changesNov 16, 2019
304ea8d toe77f6deCompareMember
nicolas-grekas commentedNov 16, 2019
Thank you@andrerom. |
nicolas-grekas added a commit that referenced this pull requestNov 16, 2019
…rerom)This PR was squashed before being merged into the 4.4 branch.Discussion----------[Cache] Redis Tag Aware warn on wrong eviction policy| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| Deprecations? | no| Tickets | n.a.| License | MIT| Doc PR | n.a.Adds validation to make sure Redis has been setup with the supported eviction policy to avoid surprises when cache suddenly is inconsistent.This PR replaces#34178, and instead of checking in constructor and throwing it only checks on save, warns about this and refuses to save cache as suggested on the other PR.TODO:- [x] ~Adapt test setups for this to set correct eviction policy~ _It already uses default noeviction_Commits-------e77f6de [Cache] Redis Tag Aware warn on wrong eviction policy
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Adds validation to make sure Redis has been setup with the supported eviction policy to avoid surprises when cache suddenly is inconsistent.
This PR replaces#34178, and instead of checking in constructor and throwing it only checks on save, warns about this and refuses to save cache as suggested on the other PR.
TODO:
Adapt test setups for this to set correct eviction policyIt already uses default noeviction