Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] Improve queries parameters display in Profiler#34384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fancyweb
Copy link
Contributor

@fancywebfancyweb commentedNov 14, 2019•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#34234
LicenseMIT
Doc PR-

 Stringable object:

The query is runnable.

Before

Screenshot 2019-11-14 at 21 05 53

After

Screenshot 2019-11-14 at 20 56 38

Non stringable object:

Exception, the query is not runnable.

Before

Screenshot 2019-11-14 at 21 05 31

After

Screenshot 2019-11-14 at 20 57 17

Error with an object:

ConversionException or a\TypeError when you specify the type when you set the parameter but you provide an invalid value and this value is an object (eg->setParameter('foo', new \stdClass(), 'date')), the query is not runnable.

Before

Screenshot 2019-11-14 at 21 04 45

After

Screenshot 2019-11-14 at 20 59 23

Error with anything else:

ConversionException or a\TypeError when you specify the type when you set the parameter but you provide an invalid value and this value is not an object (eg->setParameter('foo', 'bar', 'date')), the query is not runnable.

Before

Screenshot 2019-11-14 at 21 05 10

After

Screenshot 2019-11-14 at 20 57 54

The newrunnable key will be used inDoctrineBundle profiler template to hide theView runnable query link when the query is not runnable.

yceruto, Koc, garak, and apfelbox reacted with thumbs up emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, just minor comments.

@nicolas-grekas
Copy link
Member

Oh, please check tests on Windows, they fail.

@fancywebfancywebforce-pushed thedoctrine-bridge-object-parameter branch from5018f45 to0de1c78CompareNovember 15, 2019 12:22
@fancyweb
Copy link
ContributorAuthor

@nicolas-grekas CI is green but I had to disable colors for the cli dumper for Windows.

@fancywebfancywebforce-pushed thedoctrine-bridge-object-parameter branch from0de1c78 to9c5bb11CompareNovember 15, 2019 18:17
@fancywebfancywebforce-pushed thedoctrine-bridge-object-parameter branch from9c5bb11 tofe15f51CompareNovember 16, 2019 18:56
@fabpot
Copy link
Member

Thank you@fancyweb.

fabpot added a commit that referenced this pull requestNov 17, 2019
…filer (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[DoctrineBridge] Improve queries parameters display in Profiler| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#34234| License       | MIT| Doc PR        | -##  Stringable object:_The query is runnable._### Before<img width="773" alt="Screenshot 2019-11-14 at 21 05 53" src="https://user-images.githubusercontent.com/3658119/68892948-669cf180-0724-11ea-889b-8ce781956fc7.png">### After<img width="780" alt="Screenshot 2019-11-14 at 20 56 38" src="https://user-images.githubusercontent.com/3658119/68892978-787e9480-0724-11ea-843b-70a595633192.png">## Non stringable object:_Exception, the query is not runnable._### Before<img width="783" alt="Screenshot 2019-11-14 at 21 05 31" src="https://user-images.githubusercontent.com/3658119/68892993-80d6cf80-0724-11ea-9961-e32b65f81508.png">### After<img width="622" alt="Screenshot 2019-11-14 at 20 57 17" src="https://user-images.githubusercontent.com/3658119/68893007-87fddd80-0724-11ea-98cb-2ef695135673.png">## Error with an object:_`ConversionException` or a `\TypeError` when you specify the type when you set the parameter but you provide an invalid value and this value is an object (eg `->setParameter('foo', new \stdClass(), 'date')`), the query is not runnable._### Before<img width="775" alt="Screenshot 2019-11-14 at 21 04 45" src="https://user-images.githubusercontent.com/3658119/68893078-a9f76000-0724-11ea-9e9a-bb806ffa0a73.png">### After<img width="821" alt="Screenshot 2019-11-14 at 20 59 23" src="https://user-images.githubusercontent.com/3658119/68893098-b24f9b00-0724-11ea-8e9d-7179725b8bc1.png">## Error with anything else:_`ConversionException` or a `\TypeError` when you specify the type when you set the parameter but you provide an invalid value and this value is not an object (eg `->setParameter('foo', 'bar', 'date')`), the query is not runnable._### Before<img width="809" alt="Screenshot 2019-11-14 at 21 05 10" src="https://user-images.githubusercontent.com/3658119/68893031-93e99f80-0724-11ea-9c23-f8d05f2dbfbb.png">### After<img width="832" alt="Screenshot 2019-11-14 at 20 57 54" src="https://user-images.githubusercontent.com/3658119/68893055-9d730780-0724-11ea-8ce1-a7b8946aaf94.png">The new `runnable` key will be used in `DoctrineBundle` profiler template to hide the `View runnable query` link when the query is not runnable.Commits-------fe15f51 [DoctrineBridge] Improve queries parameters display in Profiler
@fabpotfabpot merged commitfe15f51 intosymfony:4.4Nov 17, 2019
This was referencedNov 17, 2019
@fancywebfancyweb deleted the doctrine-bridge-object-parameter branchNovember 17, 2019 17:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@fancyweb@nicolas-grekas@fabpot@javiereguiluz@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp