Since 4.3 ordering ofpreferred_choices is preserved when displaying form. But this only works for flat options. When the choices are grouped, the preferred groups are in default order.

Now the preferred choice group order is derived by taking the first matching choice frompreferred_choices and using its position to sort the groups.

carsonbot added Status: Needs Review Bug labels

Oct 23, 2019

vilius-g force-pushed theoptgroup-preffered-ordering branch frombf793b2 to97ed3bfCompare

October 23, 2019 13:20

nicolas-grekas added this to the4.3 milestone

Oct 23, 2019

xabbuh added the Form label

Oct 24, 2019

nicolas-grekas approved these changes

Nov 5, 2019

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(with minor CS comment)

src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.php OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 5, 2019

vilius-g requested a review fromxabbuh as acode owner

November 6, 2019 09:18

carsonbot added Status: Needs Review and removed Status: Reviewed labels

Nov 6, 2019

vilius-g force-pushed theoptgroup-preffered-ordering branch fromd33285a to0572b1dCompare

November 6, 2019 09:50

vilius-g requested review fromdunglas,lyrixx andsroze ascode owners

November 6, 2019 09:50

vilius-g force-pushed theoptgroup-preffered-ordering branch 2 times, most recently fromd31120d to8afaaffCompare

November 6, 2019 10:01

nicolas-grekas mentioned this pull request

Nov 6, 2019

[HttpClient] expose only gzip when doing transparent compression#34251

Merged

nicolas-grekas closed this in4f04bed

Nov 6, 2019

xabbuh reopened this

Nov 6, 2019

HeahDude approved these changes

Nov 23, 2019

View reviewed changes

Copy link

Contributor

HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.phpShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 23, 2019

nicolas-grekas changed the title~~Keep preferred_choices order for choice groups~~[Form] Keep preferred_choices order for choice groups

Nov 28, 2019

[Form] Keep preferred_choices order for choice groups

75404e5

nicolas-grekas force-pushed theoptgroup-preffered-ordering branch from8afaaff to75404e5Compare

November 28, 2019 11:24

Copy link

Member

nicolas-grekas commentedNov 28, 2019

Thank you@vilius-g.

nicolas-grekas added a commit that referenced this pull request

Nov 28, 2019

bug#34083[Form] Keep preferred_choices order for choice groups (vil…

ab5e7fa

…ius-g)This PR was squashed before being merged into the 4.3 branch.Discussion----------[Form] Keep preferred_choices order for choice groups| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |Since 4.3 ordering of `preferred_choices` is preserved when displaying form. But this only works for flat options. When the choices are grouped, the preferred groups are in default order.Now the preferred choice group order is derived by taking the first matching choice from `preferred_choices` and using its position to sort the groups.Commits-------75404e5 [Form] Keep preferred_choices order for choice groups

nicolas-grekas merged commit75404e5 intosymfony:4.3

Nov 28, 2019

This was referencedDec 1, 2019

Release v4.3.9#34741

Merged

Release v4.4.1#34742

Merged

Release v5.0.1#34743

Merged

vilius-g deleted the optgroup-preffered-ordering branch

February 1, 2020 11:36