Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Don't reset the test container but the real one instead#34078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromnicolas-grekas:hk-reset
Oct 23, 2019

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedOct 23, 2019
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

After#31202 and#32056, the tearDown method keeps throwing deprecation notices about "Getting the container from a non-booted kernel". The reason is that resetting the test-container calls$kernel->getContainer() while the kernel has been shut down.

This fixes it and a few other glitches found meanwhile.

@nicolas-grekasnicolas-grekas added this to thenext milestoneOct 23, 2019
nicolas-grekas added a commit that referenced this pull requestOct 23, 2019
…eal one instead (nicolas-grekas)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle] Don't reset the test container but the real one instead| Q             | A| ------------- | ---| Branch?       | 4.4 for features / 3.4 or 4.3 for bug fixes <!-- see below -->| Bug fix?      | yes/no| New feature?  | yes/no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", if any -->| License       | MIT| Doc PR        | -After#31202 and#32056, the tearDown method keeps throwing deprecation notices about "Getting the container from a non-booted kernel". The reason is that resetting the test-container calls `$kernel->getContainer()` while the kernel has been shut down.This fixes it and a few other glitches found meanwhile.Commits-------8e16143 [FrameworkBundle] Dont reset the test container but the real one instead
@nicolas-grekasnicolas-grekas merged commit8e16143 intosymfony:4.4Oct 23, 2019
@nicolas-grekasnicolas-grekas deleted the hk-reset branchOctober 27, 2019 10:19
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
nicolas-grekas added a commit that referenced this pull requestMar 1, 2022
…icolas-grekas)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle] Fix resetting container between tests| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#40965,fix#45580| License       | MIT| Doc PR        | -Replaces#45479 and#45581, related to#34078.Calling `boot()` on an already booted kernel does reset the container, so we don't need to care anymore about the state of kernel.#45580 is fixed by removing `private static $kernelContainer`, which can be out of sync with `static::$kernel->getContainer()` since `KernelBrowser` creates new containers when shutting down the kernel between requests.Commits-------4453bdb [FrameworkBundle] Fix resetting container between tests
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp