Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Lock] Add missing lock connection string in FrameworkExtension#34043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromjderusse:lock-connection
Oct 29, 2019

Conversation

@jderusse
Copy link
Member

@jderussejderusse commentedOct 21, 2019
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?yes
Deprecations?yes
Tickets-
LicenseMIT
Doc PRTODO

This PR adds support to missing DSN in Lock component

framework:  lock: sqlite:/tmp/db  lock: mysql:host=localhost;dbname=test  lock: zookeeper://localhost:2181

The PR also removes intermediate "internal" services.lock_connection.* in favor of factoryStoreFactory::createStore. Which remove duplicate code.

This PR also deprecate unused serviceslock.store.* andlock.store.*.abstract

@nicolas-grekas
Copy link
Member

Thank you@jderusse.

nicolas-grekas added a commit that referenced this pull requestOct 29, 2019
…Extension (jderusse)This PR was merged into the 4.4 branch.Discussion----------[Lock] Add missing lock connection string in FrameworkExtension| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| Deprecations? | yes| Tickets       | -| License       | MIT| Doc PR        | TODOThis PR adds support to missing DSN in Lock component```framework:  lock: sqlite:/tmp/db  lock: mysql:host=localhost;dbname=test  lock: zookeeper://localhost:2181```The PR also removes intermediate "internal" services `.lock_connection.*` in favor of factory `StoreFactory::createStore`. Which remove duplicate code.This PR also deprecate unused services `lock.store.*` and  `lock.store.*.abstract`Commits-------2db24cf Add missing lock connection string in FrameworkExtension
@nicolas-grekasnicolas-grekas merged commit2db24cf intosymfony:4.4Oct 29, 2019
fabpot added a commit that referenced this pull requestOct 30, 2019
…e session handler with a DSN (nicolas-grekas)This PR was merged into the 4.4 branch.Discussion----------[HttpFoundation][FrameworkBundle] allow configuring the session handler with a DSN| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -```yamlframework:    session:        handler_id: 'redis://localhost'        handler_id: '%env(REDIS_URL)%'        handler_id: '%env(DATABASE_URL)%'        handler_id: 'file://%kernel.project_dir%/var/sessions'```etc.the database connection is not shared with the ORM (don't mess with transactions.)redis/memcached connections are shared between cache and session.(as a reminder, cache and ORM share the db connection: we're ok with trashing the cache on a rollback)Lock-related changes are a follow up of#34043.(fabbot failure is false positive)Commits-------de9c61f [HttpFoundation][FrameworkBundle] allow configuring the session handler with a DSN
nicolas-grekas added a commit that referenced this pull requestNov 7, 2019
…web)This PR was merged into the 5.0-dev branch.Discussion----------[FrameworkBundle] Remove Lock deprecated services| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Remove deprecated services in#34043.Commits-------a8e10cf [FrameworkBundle] Remove Lock deprecated services
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestNov 7, 2019
…web)This PR was merged into the 5.0-dev branch.Discussion----------[FrameworkBundle] Remove Lock deprecated services| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Remove deprecated services insymfony/symfony#34043.Commits-------a8e10cffbb [FrameworkBundle] Remove Lock deprecated services
This was referencedNov 12, 2019
@jderussejderusse deleted the lock-connection branchMarch 5, 2020 20:03
wouterj added a commit to symfony/symfony-docs that referenced this pull requestOct 4, 2020
This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead.Discussion----------Add a documentation page for lock in FWThis PR add a dedicated page to explain how to use Lock with FrameworkBundleThis PR slightly depends onsymfony/symfony#34043 (PDO and Zookeeper DSN)I should have pushed this PR years ago 😢  sorry about that...Fixes:#12561Commits-------8bf4f85 Add a documentation page for lock in FW
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@jderusse@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp