Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] add RocketChat bridge#34022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromJeroeny:rocketchat
Feb 10, 2020
Merged

Conversation

@Jeroeny
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsSee#33687
LicenseMIT

This would addRocketChat integration for the Notifier component. RocketChat is a self hosted chat service.

Fully tested with a trial version of RocketChat.

@Wirone I noticed you suggested this.

Wirone, mleczakm, and andreybolonin reacted with thumbs up emojiengelgabriel reacted with heart emoji
@Wirone
Copy link
Contributor

@Jeroeny yeah, I suggested it and even thought about implementation, but you were first 😉 👍

OskarStark, Jeroeny, and andreybolonin reacted with thumbs up emoji

@Jeroeny
Copy link
ContributorAuthor

Jeroeny commentedNov 13, 2019•
edited
Loading

Is this good to go?

Edit: Actually, looking at#33875, I think it's missing:

  • Symfony/Component/Notifier/Transport.php Factory class
  • Framework extension entry and config change
  • Notifier/Exception/UnsupportedSchemeException.php entry

Edit: Fixed

@Jeroeny
Copy link
ContributorAuthor

Because I updated from the 5.0 upstream branch, which was wrong, I had 600+ commits as diff, also causing GitHub to request reviews from code owners. My bad, I reverted that push.

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me

@fabpot
Copy link
Member

@Jeroeny Can you rebase to get rid of the merge commit? Thank you.

@fabpot
Copy link
Member

Thank you@Jeroeny.

Jeroeny reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

+2 more reviewers

@thePanzthePanzthePanz left review comments

@antiseptikkantiseptikkantiseptikk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

9 participants

@Jeroeny@Wirone@fabpot@thePanz@OskarStark@antiseptikk@nicolas-grekas@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp