Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor#34019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedOct 18, 2019
It looks like reading |
savedario commentedOct 18, 2019
As in: make getCsvOptions() return two extra variables ? |
savedario commentedOct 23, 2019
I tried, but when it was time to update the test, I realized that getCsvOptions() returns a different set of variables in encode() v/s decode(). |
savedario commentedOct 25, 2019
My proposed changes are done, but I don't know how to correct the failing AppVeyor... |
nicolas-grekas commentedNov 28, 2019
Thank you@savedario. |
…in constructor (Dario Savella)This PR was squashed before being merged into the 4.3 branch.Discussion----------[Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| Deprecations? | no| License | MITMy first pull request...The following code:```$data = <<<EODa,bc,dEOD;$encoder = new CsvEncoder([CsvEncoder::NO_HEADERS_KEY=>true]);var_dump($encoder->decode($data,'csv'));```produces:```array(2) { 'a' => string(1) "c" 'b' => string(1) "d"}```instead of the expected:```array(2) { [0] => array(2) { [0] => string(1) "a" [1] => string(1) "b" } [1] => array(2) { [0] => string(1) "c" [1] => string(1) "d" }}```Commits-------a0430f6 [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor…n used in constructor (Dario Savella)This PR was squashed before being merged into the 4.3 branch.Discussion----------[Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| Deprecations? | no| License | MITMy first pull request...The following code:```$data = <<<EODa,bc,dEOD;$encoder = new CsvEncoder([CsvEncoder::NO_HEADERS_KEY=>true]);var_dump($encoder->decode($data,'csv'));```produces:```array(2) { 'a' => string(1) "c" 'b' => string(1) "d"}```instead of the expected:```array(2) { [0] => array(2) { [0] => string(1) "a" [1] => string(1) "b" } [1] => array(2) { [0] => string(1) "c" [1] => string(1) "d" }}```Commits-------a0430f6 [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
Uh oh!
There was an error while loading.Please reload this page.
My first pull request...
The following code:
produces:
instead of the expected: