Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Firebase bridge#33968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromJeroeny:notifier
Feb 10, 2020
Merged

Conversation

Jeroeny
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsSee#33687
LicenseMIT

This would addFirebase integration for the Notifier component. With Firebase you can send push notifications to the users of you Android and iOS app and website (formerly known as Google Cloud messaging).

I'm not sure if it's possible to have this merged, like the other bridges. Or if I should create a stand-alone repository? That'd be fine too.

Also it's now using theChatMessage as implementation ofSymfony\Component\Notifier\Message\MessageInterface, but I feel like this component could use aPushMessage or something similar. Although I'm not sure if it would contain more thansubject that theChatMessage does.

OskarStark, kevin-verschaeve, andreybolonin, GromNaN, and quentin-st reacted with thumbs up emoji
@nicolas-grekasnicolas-grekas added this to the5.0 milestoneOct 13, 2019
@nicolas-grekasnicolas-grekas modified the milestones:5.0,nextNov 6, 2019
@fabpot
Copy link
Member

Thank you@Jeroeny.

Jeroeny reacted with thumbs up emoji

@acasademont
Copy link
Contributor

After seeing fabpot's talk today talking about the Firebase notifier coming in 5.1 I looked at the repo and noticed that this Firebase notifier is based on the old Http API, that allows quite a lot less options than the new one, specifically, the new one allows you to send in 1 message different options for different platforms (iOS, Android, Web) instead of having to send separate messages for each of the platforms.

Not sure@Jeroeny if this is something that should be changed before the 5.1 release?

https://firebase.google.com/docs/cloud-messaging/migrate-v1

@fabpot
Copy link
Member

@acasademont I would recommend to open a new issue.

acasademont and OskarStark reacted with thumbs up emoji

@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@noniagriconomienoniagriconomienoniagriconomie left review comments

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

8 participants
@Jeroeny@fabpot@acasademont@OskarStark@noniagriconomie@nicolas-grekas@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp