Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DI] Unknown env prefix not recognized as such#33960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromro0NL:di-env
Feb 4, 2020
Merged

[DI] Unknown env prefix not recognized as such#33960

nicolas-grekas merged 1 commit intosymfony:4.4fromro0NL:di-env
Feb 4, 2020

Conversation

@ro0NL
Copy link
Contributor

QA
Branch?4.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

This is a failing test to illustrate the difference between real and fake env vars when using an unknown prefix, followed by thedefault prefix.

%env(unknown:default::REAL)%// Unsupported env var prefix "unknown".%env(unknown:default::FAKE)%// null

Fordefault::FAKE we getnull at

return'' ===$default ?null :$this->container->getParameter($default);

which is then preserved at

need inspiration for a patch still :)

@ro0NLro0NL changed the title[DI] Unknown env prefix not regornized as such[DI] Unknown env prefix not recognized as suchOct 11, 2019
@nicolas-grekasnicolas-grekas added this to the4.3 milestoneOct 12, 2019
@nicolas-grekasnicolas-grekas modified the milestones:4.3,4.4Feb 1, 2020
@nicolas-grekasnicolas-grekas changed the base branch from4.3 to4.4February 4, 2020 15:57
@nicolas-grekas
Copy link
Member

Thank you@ro0NL.

nicolas-grekas added a commit that referenced this pull requestFeb 4, 2020
This PR was submitted for the 4.3 branch but it was merged into the 4.4 branch instead.Discussion----------[DI] Unknown env prefix not recognized as such| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->This is a failing test to illustrate the difference between real and fake env vars when using an unknown prefix, followed by the `default` prefix.```%env(unknown:default::REAL)%// Unsupported env var prefix "unknown".%env(unknown:default::FAKE)%// null```For `default::FAKE` we get `null` athttps://github.com/symfony/symfony/blob/38b9a27976d36c4ffbfeb9e666319d77ffc8b3c0/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php#L103which is then preserved athttps://github.com/symfony/symfony/blob/38b9a27976d36c4ffbfeb9e666319d77ffc8b3c0/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php#L123need inspiration for a patch still :)Commits-------550819a [DI] Unknown env prefix not regornized as such
@nicolas-grekasnicolas-grekas merged commit550819a intosymfony:4.4Feb 4, 2020
@ro0NLro0NL deleted the di-env branchFebruary 5, 2020 12:20
This was referencedFeb 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@ro0NL@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp