Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Fix ValidValidator group cascading usage#33834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesOct 4, 2019
xabbuh approved these changesOct 7, 2019
Member
xabbuh commentedOct 7, 2019
Thank you@fancyweb. |
xabbuh added a commit that referenced this pull requestOct 7, 2019
…yweb)This PR was merged into the 3.4 branch.Discussion----------[Validator] Fix ValidValidator group cascading usage| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -`$this->context->getGroup()` returns `string` or `null`.`ContextualValidatorInterface::validate()` 3rd argument accepts an array but it must not contain `null` (its contract doesn't allow it). If it does, it will fail in `RecursiveContextualValidator::validateInGroup()` for example because of the `string` scalar type on the `$group` argument. (on 4.4)Note that in our "common" usage of the `Valid` constraint, the group in its validator will never be `null` because this constraint has a special treatment. However, if this validator is reused in a custom way, it can fail.Commits-------72684b0 [Validator] Fix ValidValidator group cascading usage
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
$this->context->getGroup()returnsstringornull.ContextualValidatorInterface::validate()3rd argument accepts an array but it must not containnull(its contract doesn't allow it). If it does, it will fail inRecursiveContextualValidator::validateInGroup()for example because of thestringscalar type on the$groupargument. (on 4.4)Note that in our "common" usage of the
Validconstraint, the group in its validator will never benullbecause this constraint has a special treatment. However, if this validator is reused in a custom way, it can fail.