Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array#33814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4frommynameisbogdan:ticket_33769
Oct 2, 2019
Merged

Conversation

@mynameisbogdan
Copy link
Contributor

[HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array

QA
Branch?4.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#33769
LicenseMIT

If$_SESSION['_sf2_attributes'] is set to a string,SessionBagProxy::initialize will throw an error since it's argument is type-hinted as array. So this change is to check before if the data to be passed is truly an array.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(merging on 3.4)

@nicolas-grekasnicolas-grekas changed the base branch from4.3 to3.4October 2, 2019 16:15
@nicolas-grekas
Copy link
Member

Thank you@mynameisbogdan.

mynameisbogdan reacted with hooray emoji

nicolas-grekas added a commit that referenced this pull requestOct 2, 2019
…initialize is an array (mynameisbogdan)This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes#33814).Discussion----------[HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array[HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#33769 <!-- prefix each issue number with "Fix #", if any -->| License       | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->If `$_SESSION['_sf2_attributes']` is set to a string, `SessionBagProxy::initialize` will throw an error since it's argument is type-hinted as array. So this change is to check before if the data to be passed is truly an array.Commits-------38782bc [HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array
@nicolas-grekasnicolas-grekas merged commit38782bc intosymfony:3.4Oct 2, 2019
This was referencedOct 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mynameisbogdan@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp