NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] Throw a TypeError for non-int return value calling Command::execute()#33808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 3 commits intosymfony:masterfromjschaedl:issue-33747-2

Oct 2, 2019

Merged

[Console] Throw a TypeError for non-int return value calling Command::execute()#33808

nicolas-grekas merged 3 commits intosymfony:masterfromjschaedl:issue-33747-2

Oct 2, 2019

Conversation

Copy link

Contributor

jschaedl commentedOct 2, 2019•
edited
Loading

Q	A
Branch?	5.0
Bug fix?	no
New feature?	no
Deprecations?	yes
Tickets	Fix#33747
License	MIT
Doc PR	-

Todo

needs to be rebased after 4.4 was merged into master (see:[FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand #33805)

carsonbot added Status: Needs Review Console Deprecation labels

Oct 2, 2019

jschaedl force-pushed theissue-33747-2 branch fromd36460d tob468124Compare

October 2, 2019 12:56

jschaedl mentioned this pull request

Oct 2, 2019

Command::execute() should always return int - deprecate returning null#33747

Closed

jschaedl force-pushed theissue-33747-2 branch fromb468124 to5e93acaCompare

October 2, 2019 12:58

jschaedl marked this pull request as ready for review

October 2, 2019 15:01

jschaedl force-pushed theissue-33747-2 branch from5e93aca to4a798b4Compare

October 2, 2019 15:08

nicolas-grekas added this to the5.0 milestone

Oct 2, 2019

nicolas-grekas reviewed

Oct 2, 2019

View reviewed changes

src/Symfony/Component/Console/Command/Command.php OutdatedShow resolvedHide resolved

jschaedl force-pushed theissue-33747-2 branch 2 times, most recently from81b5ba6 toa7f0ae1Compare

October 2, 2019 17:13

jschaedl changed the title~~[Console] Throw an Exception for non-int return value calling Command::execute()~~[Console] Throw a TypeError for non-int return value calling Command::execute()

Oct 2, 2019

nicolas-grekas reviewed

Oct 2, 2019

View reviewed changes

src/Symfony/Component/Console/Command/Command.php OutdatedShow resolvedHide resolved

nicolas-grekasand others added3 commits

October 2, 2019 19:19

fix typo

3b16551

Merge branch '4.4'

95ebca5

* 4.4:  fix typo

[Console] Throw a TypeError for non-int return values on calling Comm…

b3a3b0c

…and::execute()

nicolas-grekas added BC Break and removed Deprecation labels

Oct 2, 2019

nicolas-grekas force-pushed theissue-33747-2 branch froma7f0ae1 tob3a3b0cCompare

October 2, 2019 17:22

nicolas-grekas added a commit that referenced this pull request

Oct 2, 2019

minor#33808[Console] Throw a TypeError for non-int return value cal…

ebda9d1

…ling Command::execute() (jschaedl)This PR was merged into the 5.0-dev branch.Discussion----------[Console] Throw a TypeError for non-int return value calling Command::execute()| Q             | A| ------------- | ---| Branch?       | 5.0| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#33747 <!-- prefix each issue number with "Fix #", if any -->| License       | MIT| Doc PR        | - <!-- required for new features -->### Todo- [x] needs to be rebased after 4.4 was merged into master (see:#33805)Commits-------b3a3b0c [Console] Throw a TypeError for non-int return values on calling Command::execute()