Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security]: Don't let falsy usernames slip through impersonation#33799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/Symfony/Component/Security/Http/Firewall/SwitchUserListener.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
chalasr approved these changesOct 2, 2019
wouterj approved these changesOct 2, 2019
maxhelias approved these changesOct 3, 2019
xabbuh approved these changesOct 3, 2019
Member
chalasr commentedOct 3, 2019
Thank you@j4nr6n. |
chalasr added a commit that referenced this pull requestOct 3, 2019
…nation (j4nr6n)This PR was merged into the 3.4 branch.Discussion----------[Security]: Don't let falsy usernames slip through impersonation| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |When you try to impersonate users with a falsy username, `SwitchUserListener::handle()` would `return;` and impersonation would fail.I'm using a third party OAuth provider that allows users to change their usernames with no guaranteed protection against re-use. To overcome that issue, I implemented `UserLoaderInterface::loadUserByUsername()` and query by a `providerId`.After loading development fixtures, One user has `0` as it's `providerId`.Commits-------64aecab Don't let falsey usernames slip through
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you try to impersonate users with a falsy username,
SwitchUserListener::handle()wouldreturn;and impersonation would fail.I'm using a third party OAuth provider that allows users to change their usernames with no guaranteed protection against re-use. To overcome that issue, I implemented
UserLoaderInterface::loadUserByUsername()and query by aproviderId.After loading development fixtures, One user has
0as it'sproviderId.