Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix the :only-of-type pseudo class selector#33777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jakzal commentedSep 30, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#33773 |
| License | MIT |
| Doc PR | - |
53864f1 to988405cCompare| foreach ($elementsas$element) { | ||
| if (null !==$element->attributes()->id) { | ||
| $this->assertTrue(\in_array($element->attributes()->id,$elementsId)); | ||
| $this->assertContains((string)$element->attributes()->id,$elementsId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not strictly related, but it improves an error message shown when the test fails. Before the change, the message would say "expected true, got false". Now it will indicate what's the missing id.
9bfc715 tobd314d3Comparebd314d3 toc2a9bf0Comparefabpot commentedOct 1, 2019
Thank you@jakzal. |
This PR was squashed before being merged into the 3.4 branch (closes#33777).Discussion----------Fix the :only-of-type pseudo class selector| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#33773| License | MIT| Doc PR | -Commits-------c2a9bf0 Fix the :only-of-type pseudo class selector