Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[String] Introduce a locale-aware Slugger in the String component#33768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromtgalopin:string-slugger
Oct 2, 2019

Conversation

@tgalopin
Copy link
Contributor

@tgalopintgalopin commentedSep 30, 2019•
edited by nicolas-grekas
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

This PR introduces a locale-aware Slugger in the new String component, based on transliterators provided by the PHP intl extension (or iconv if not available). It also wires this Slugger in the FrameworkBundle in order to use it easily as a service and to automatically inject the proper locale into it to choose the appropriate transliteration depending on the Request locale.

Seehttps://github.com/unicode-org/cldr/tree/master/common/transforms for CLDR mappings.

yceruto, nicolas-grekas, javiereguiluz, pamil, and chr-hertel reacted with hooray emojiCapenus, nicolas-grekas, javiereguiluz, pamil, chr-hertel, EmilCataranciuc, and emullaraj reacted with heart emoji
@tgalopintgalopinforce-pushed thestring-slugger branch 9 times, most recently from26c170a toe6c9ff3CompareOctober 2, 2019 13:32
@tgalopintgalopinforce-pushed thestring-slugger branch 2 times, most recently from5491b6f to9c0b619CompareOctober 2, 2019 13:47
Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I love this! This will be immensely useful 😍 Thanks Titouan!

tgalopin reacted with heart emojiOskarStark reacted with rocket emoji
@nicolas-grekas
Copy link
Member

Thank you@tgalopin.

nicolas-grekas added a commit that referenced this pull requestOct 2, 2019
…g component (tgalopin)This PR was merged into the 5.0-dev branch.Discussion----------[String] Introduce a locale-aware Slugger in the String component| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -This PR introduces a locale-aware Slugger in the new String component, based on transliterators provided by the PHP intl extension (or iconv if not available). It also wires this Slugger in the FrameworkBundle in order to use it easily as a service and to automatically inject the proper locale into it to choose the appropriate transliteration depending on the Request locale.Seehttps://github.com/unicode-org/cldr/tree/master/common/transforms for CLDR mappings.Commits-------056d8ce [String] Introduce a locale-aware Slugger in the String component with FrameworkBundle wiring
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@ycerutoycerutoyceruto left review comments

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@tgalopin@nicolas-grekas@javiereguiluz@stof@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp