Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security/Http] fix parsing X509 emailAddress#33759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedSep 30, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#33636 |
| License | MIT |
| Doc PR | - |
javiereguiluz approved these changesSep 30, 2019
chalasr approved these changesSep 30, 2019
fabpot approved these changesSep 30, 2019
Member
fabpot commentedSep 30, 2019
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestSep 30, 2019
…kas)This PR was merged into the 3.4 branch.Discussion----------[Security/Http] fix parsing X509 emailAddress| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#33636| License | MIT| Doc PR | -Commits-------fceb86b [Security/Http] fix parsing X509 emailAddress
fabpot added a commit that referenced this pull requestDec 18, 2022
…nticator (Spomky)This PR was squashed before being merged into the 6.3 branch.Discussion----------[Security] Allow custom user identifier for X509 authenticator| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#47354| License | MIT| Doc PR | **to be created**This PR allows defining a custom user identifier instead of the hardcoded `emailAddress`.It also adds a new option for the firewall configuration:```yaml# config/packages/security.yamlsecurity: # ... firewalls: main: # ... x509: provider: your_user_provider user_identifier: CN # default to emailAddress```**💬 Discussion**: user identifier regex changedNote that the regex is changed. The previous one was able to find an email address as expected, but now that the common name may not contain a `@` (or may contain more than one), it is required to update this part.It does not impact the previously merged PR#33759, but I prefer highlight the fact that it can now catch invalid email addresses set in `emailAddress`.Commits-------6479653 [Security] Allow custom user identifier for X509 authenticator
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.