Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] added AccessMapInterface#3374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 2 commits intosymfony:masterfromkriswallsmith:security/access-map-interfaceFeb 16, 2012
Merged
[Security] added AccessMapInterface#3374
fabpot merged 2 commits intosymfony:masterfromkriswallsmith:security/access-map-interfaceFeb 16, 2012
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
kriswallsmith commentedFeb 15, 2012
For conversation:https://gist.github.com/1839490 |
Contributor
jwage commentedFeb 16, 2012
👍 |
fabpot added a commit that referenced this pull requestFeb 16, 2012
Commits-------eb7aa1b [SecurityBundle] added interface to compiler1e8236c [Security] added AccessMapInterfaceDiscussion----------[Security] added AccessMapInterfaceI am optimizing the security layer at OpenSky and need to make this class smarter instead of running through all of the many access rules for each request. I would like to do this by creating a delegating access map composed of many inner maps and would rather implement an interface than extending a core class without using any of its functionality.```Bug fix: noFeature addition: noBackwards compatibility break: noSymfony2 tests pass: yesFixes the following tickets: -Todo: -```---------------------------------------------------------------------------by kriswallsmith at 2012-02-15T22:31:36ZFor conversation:https://gist.github.com/1839490---------------------------------------------------------------------------by jwage at 2012-02-16T03:57:09Z:+1:
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am optimizing the security layer at OpenSky and need to make this class smarter instead of running through all of the many access rules for each request. I would like to do this by creating a delegating access map composed of many inner maps and would rather implement an interface than extending a core class without using any of its functionality.