Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] remove deprecated code paths#33697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedSep 25, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
fabpot commentedSep 25, 2019
Thank you@xabbuh. |
This PR was merged into the 5.0-dev branch.Discussion----------[Security] remove deprecated code paths| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Commits-------2b6ce01 remove deprecated code paths
ostrolucky commentedSep 26, 2019
shouldn't the change be reflected in docblock? |
xabbuh commentedSep 26, 2019
@ostrolucky Can you create a PR (targetting the |
| } | ||
| return$this->accessDecisionManager->decide($token,$attributes,$subject); | ||
| return$this->accessDecisionManager->decide($token,(array)$attributes,$subject); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
An array cast doesn't work here since$attributes can be an object, we could use[$attributes] instead since it can't be an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
only if $attributes is not null
would you mind sending a PR (with a test case ideally)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Even if$attributes isnull, we should pass[null] todecide.
PR created :#33721
This PR was merged into the 5.0-dev branch.Discussion----------[Security] Fix isGranted with object attribute| Q | A| ------------- | ---| Branch? | master (the added test could be backported to older branches)| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#33697 (comment)| License | MIT| Doc PR |Fix calls to isGranted with `$attribute` beeing an object.Commits-------3a5fd48 Fix isGranted with object attribute