Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] use LegacyEventDispatcherProxy#33693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
0441a01 toefac5bbCompareefac5bb to7067e48Comparenicolas-grekas approved these changesSep 24, 2019
OskarStark approved these changesSep 24, 2019
javiereguiluz approved these changesSep 25, 2019
maxhelias approved these changesSep 25, 2019
xabbuh approved these changesSep 25, 2019
Member
xabbuh commentedSep 25, 2019
Thank you David. |
xabbuh added a commit that referenced this pull requestSep 25, 2019
This PR was merged into the 4.3 branch.Discussion----------[Security] use LegacyEventDispatcherProxy| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -I ran into an issue on one of my apps that has its own event dispatcher class using the old dispatch method signature```phppublic function dispatch($eventName, Event $event = null)```This leads to```TypeError: Argument 2 passed to X\Tests\Base\TestEventDispatcher::dispatch() must be an instance of Symfony\Component\EventDispatcher\Event or null, string given, called in /var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php on line 230/var/www/x/symfony/tests/Base/TestEventDispatcher.php:20/var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php:230/var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php:111```since the event here is dispatched using the new signature:https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L259Commits-------7067e48 [Security] use LegacyEventDispatcherProxy
This was referencedSep 25, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue on one of my apps that has its own event dispatcher class using the old dispatch method signature
This leads to
since the event here is dispatched using the new signature:
https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L259