Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] use LegacyEventDispatcherProxy#33693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:4.3fromdmaicher:dispatcher_proxy
Sep 25, 2019

Conversation

@dmaicher
Copy link
Contributor

QA
Branch?4.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

I ran into an issue on one of my apps that has its own event dispatcher class using the old dispatch method signature

publicfunction dispatch($eventName,Event$event =null)

This leads to

TypeError: Argument 2 passed to X\Tests\Base\TestEventDispatcher::dispatch() must be an instance of Symfony\Component\EventDispatcher\Event or null, string given, called in /var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php on line 230/var/www/x/symfony/tests/Base/TestEventDispatcher.php:20/var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php:230/var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php:111

since the event here is dispatched using the new signature:

https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L259

egircys reacted with thumbs up emoji
@xabbuhxabbuh added this to the4.3 milestoneSep 25, 2019
@xabbuh
Copy link
Member

Thank you David.

dmaicher reacted with thumbs up emoji

xabbuh added a commit that referenced this pull requestSep 25, 2019
This PR was merged into the 4.3 branch.Discussion----------[Security] use LegacyEventDispatcherProxy| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -I ran into an issue on one of my apps that has its own event dispatcher class using the old dispatch method signature```phppublic function dispatch($eventName, Event $event = null)```This leads to```TypeError: Argument 2 passed to X\Tests\Base\TestEventDispatcher::dispatch() must be an instance of Symfony\Component\EventDispatcher\Event or null, string given, called in /var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php on line 230/var/www/x/symfony/tests/Base/TestEventDispatcher.php:20/var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php:230/var/www/x/symfony/vendor/symfony/security/Http/Firewall/ContextListener.php:111```since the event here is dispatched using the new signature:https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L259Commits-------7067e48 [Security] use LegacyEventDispatcherProxy
@xabbuhxabbuh merged commit7067e48 intosymfony:4.3Sep 25, 2019
@dmaicherdmaicher deleted the dispatcher_proxy branchSeptember 25, 2019 10:35
@fabpotfabpot mentioned this pull requestOct 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@dmaicher@xabbuh@javiereguiluz@nicolas-grekas@OskarStark@maxhelias@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp