Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add missing row_attr option to FormType#33688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:4.3frommcsky:fix/form_row_attr_option
Sep 25, 2019

Conversation

@mcsky
Copy link

QA
Branch?4.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix:#33682 - related issue#33573
LicenseMIT

The#33573 modified Symfony's form themes. But theFormType don't allow the optionrow_attr so the OptionResolver throw an exception that the option is unknown.

This PR basically add the option and give it to the form view (likelabel_attr do)

khylias and l-vo reacted with thumbs up emoji
@stof
Copy link
Member

This should actually be added in BaseType, so that ButtonType also benefits from it, not only FormType.

@mcskymcskyforce-pushed thefix/form_row_attr_option branch fromb7d6d9d tod711ea2CompareSeptember 24, 2019 15:38
@mcsky
Copy link
Author

Good catch, PR updated

@fancyweb
Copy link
Contributor

Noticed this while working on#33573. Didn't change it because I thought it was like this on purpose and it is justified for me to offer this feature only in the theme. But by looking at#30320, it's clear the initial idea was to add the form option as well. Not really a fan of adding another theming form option though. Also, if we had this one, why don't we add the others ?

@xabbuhxabbuh added the Form labelSep 25, 2019
@xabbuhxabbuh added this to the4.3 milestoneSep 25, 2019
@xabbuh
Copy link
Member

Thank you@mcsky.

xabbuh added a commit that referenced this pull requestSep 25, 2019
This PR was merged into the 4.3 branch.Discussion----------Add missing row_attr option to FormType| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix:#33682 - related issue#33573| License       | MITThe#33573 modified Symfony's form themes. But the [FormType](https://github.com/symfony/form/blob/master/Extension/Core/Type/FormType.php) don't allow the option `row_attr` so the OptionResolver throw an exception that the option is unknown.This PR basically add the option and give it to the form view (like `label_attr` do)Commits-------d711ea2 Add missing row_attr option to FormType
@xabbuhxabbuh merged commitd711ea2 intosymfony:4.3Sep 25, 2019
@fabpotfabpot mentioned this pull requestOct 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@mcsky@stof@fancyweb@xabbuh@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp