Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Notifier Component#33687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromfabpot:notifier-feature-v1
Oct 5, 2019
Merged

Conversation

@fabpot
Copy link
Member

@fabpotfabpot commentedSep 24, 2019•
edited
Loading

QA
Branch?5.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PRnot yet

Initial PR for the Notifier component. Tests missing for now.

yceruto, tony-tran, javiereguiluz, linaori, TomasVotruba, leocavalcante, maxhelias, Jeroeny, DylanDelobel, bonfante, and 20 more reacted with thumbs up emojiyceruto, javiereguiluz, linaori, K1ngMX, monteiro, nicolas-grekas, OlivierToussaint, ck-developer, 1ed, ChristianVermeulen, and 5 more reacted with hooray emojiDavidBadura reacted with confused emojiyceruto, OskarStark, javiereguiluz, linaori, K1ngMX, monteiro, nicolas-grekas, ck-developer, andreybolonin, and birkof reacted with heart emojiyceruto, Nek-, OskarStark, javiereguiluz, linaori, bonfante, monteiro, rubenrua, ck-developer, andreybolonin, and FriTOol reacted with rocket emoji
@fabpotfabpot changed the titleNotifier feature v1Notifier ComponentSep 24, 2019
Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just minor CS so far ;)

@ycerutoyceruto added this to thenext milestoneSep 24, 2019
@fabpotfabpotforce-pushed thenotifier-feature-v1 branch 6 times, most recently frome25fd0f to47c4b0aCompareSeptember 25, 2019 20:35
@fabpotfabpot changed the base branch from4.4 tomasterSeptember 25, 2019 20:35
@fabpotfabpot removed this from thenext milestoneSep 25, 2019
@Wirone
Copy link
Contributor

Wirone commentedOct 4, 2019•
edited
Loading

@fabpot@nicolas-grekas Side question: why are you amending changes all the time? In this case it's impossible to see changes introduced on each step of the review process, so when new version of a branch is pushed I don't know what should be reviewed again (Github marks whole files as "changed since last view", with large files it's difficult to read whole file every time). I recommend adding new commits and squash them just before merging, if you want to keep compact history.

Edit: ahh, Github generatescompare view for those pushes, but they're linked under "force pushed" and it's not intuitive and transparent since text is not decorated in any way. In Gitlab there is "Compare with previous version" link, much easier to notice.

rob006 and sstok reacted with thumbs up emoji

@fabpot
Copy link
MemberAuthor

fabpot commentedOct 5, 2019•
edited
Loading

For some reasons, some of my comments were not published :(

sstok reacted with confused emoji

@fabpot
Copy link
MemberAuthor

@Wirone About providers that could be implemented: this initial PR provides just a few of the possible/popular providers to get us started. I hope that many other ones will be submitted over time.

RegardingsetXxx() methos vsxxx() ones: I only used thexxx() styles for data objects.

Wirone and sstok reacted with thumbs up emoji

@fabpotfabpotforce-pushed thenotifier-feature-v1 branch 2 times, most recently from2554b5c to0b219b9CompareOctober 5, 2019 10:38
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's merge and accept followups to tweak the rest, add tests, etc.
Help wanted!

@nicolas-grekas
Copy link
Member

Thanks@fabpot for working on this feature, this is much appreciated.

yceruto and npotier reacted with heart emoji

nicolas-grekas added a commit that referenced this pull requestOct 5, 2019
This PR was merged into the 5.0-dev branch.Discussion----------Notifier Component| Q             | A| ------------- | ---| Branch?       | 5.0| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       || License       | MIT| Doc PR        | not yetInitial PR for the Notifier component. Tests missing for now.Commits-------7f97a3f [Notifier] added the component
@nicolas-grekasnicolas-grekas merged commit7f97a3f intosymfony:masterOct 5, 2019
@fabpotfabpot mentioned this pull requestNov 12, 2019
fabpot added a commit that referenced this pull requestNov 30, 2019
This PR was squashed before being merged into the 5.0 branch (closes#34549).Discussion----------[Notifier] Add Slack bridge tests| Q             | A| ------------- | ---| Branch?       | 5.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | See#33687| License       | MITAdds tests for the Slack bridge of the Notifier component.#SymfonyHackdayCommits-------626fdaa [Notifier] Add Slack bridge tests
fabpot added a commit that referenced this pull requestNov 30, 2019
This PR was squashed before being merged into the 5.0 branch (closes#34539).Discussion----------[Notifier] Add telegram tests| Q             | A| ------------- | ---| Branch?       | 5.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | See#33687| License       | MITAdds tests for the Telegram bridge of the Notifier component. Not sure if this is the right way to go, but would love some feedback.#SymfonyHackdayCommits-------3b4d83c [Notifier] Add telegram tests
fabpot added a commit that referenced this pull requestFeb 10, 2020
This PR was merged into the 5.1-dev branch.Discussion----------Add Mattermost notifier bridge| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |  See#33687| License       | MIT| Doc PR        |Added ahttp://mattermost.org (open source Slack alternative)  transport for the new Notifier componentCommits-------eaba6a5 Add Mattermost notifier bridge
fabpot added a commit that referenced this pull requestFeb 10, 2020
This PR was squashed before being merged into the 5.1-dev branch (closes#34022).Discussion----------[Notifier] add RocketChat bridge| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | See#33687| License       | MITThis would add [RocketChat](https://rocket.chat/) integration for the Notifier component. RocketChat is a self hosted chat service.Fully tested with a trial version of RocketChat.@Wirone I noticed you suggested this.Commits-------4869ef6 [Notifier] add RocketChat bridge
fabpot added a commit that referenced this pull requestFeb 10, 2020
This PR was squashed before being merged into the 5.1-dev branch (closes#33968).Discussion----------[Notifier] Add Firebase bridge| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | See#33687| License       | MITThis would add [Firebase](https://firebase.google.com) integration for the Notifier component. With Firebase you can send push notifications to the users of you Android and iOS app and website (formerly known as Google Cloud messaging).I'm not sure if it's possible to have this merged, like the other bridges. Or if I should create a stand-alone repository? That'd be fine too.Also it's now using the `ChatMessage` as implementation of `Symfony\Component\Notifier\Message\MessageInterface`, but I feel like this component could use a `PushMessage` or something similar. Although I'm not sure if it would contain more than `subject` that the `ChatMessage` does.Commits-------2776d2f [Notifier] Add Firebase bridge
fabpot added a commit that referenced this pull requestFeb 11, 2020
This PR was squashed before being merged into the 5.1-dev branch.Discussion----------[Notifier] add OvhCloud bridge| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | See#33687| License       | MITThis would add OvhCloud sms integration for the Notifier component.Tested with 'ovh-eu' entrypoint.Inspiration :https://github.com/ovh/php-ovhCommits-------76bfb85 [Notifier] add OvhCloud bridge
@DeamonDeamon mentioned this pull requestApr 30, 2020
fabpot added a commit that referenced this pull requestAug 6, 2020
This PR was merged into the 5.2-dev branch.Discussion----------[Notifier] Add Zulip notifier bridge| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | See#33687| License       | MIT| Doc PR        |symfony/symfony-docs#13604This adds a [Zulip](https://zulipchat.com/) (another popular open source Slack alternative) transport for the new Notifier component.#### Sample DSN```ZULIP_DSN=zulip://test-bot@zulipchat.com:api-key@example.zulipchat.com?channel=builds```#### Configuration```yml# config/packages/notifier.yamlframework:    notifier:        chatter_transports:            zulip: '%env(ZULIP_DSN)%'```#### Example```phppublic function index(ChatterInterface $chatter){    $message = (new ChatMessage('New order arrived!', new ZulipOptions('Ordering')))        ->transport('zulip');    $chatter->send($message);    ...}```Commits-------bd4fd32 Adds Zulip notifier bridge
fabpot added a commit that referenced this pull requestAug 13, 2020
This PR was merged into the 5.2-dev branch.Discussion----------[Notifier] Add Mobyt bridge| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |#33687| License       | MIT| Doc PR        |symfony/symfony-docs#13606| recipe PR   |symfony/recipes#768Add Mobyt notifier bridge.In this SMS Provider, you can choose a sort of "quality service" to send the message.I updated `src/Symfony/Component/Notifier/Message/SmsMessage.php` to add the notification in order to be able to use the notification importance when creating options.Commits-------bf594b7 Add Mobyt Notifier bridge
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxlyrixx left review comments

@stofstofstof left review comments

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@ycerutoycerutoyceruto left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

+8 more reviewers

@tigitztigitztigitz left review comments

@TaluuTaluuTaluu left review comments

@WironeWironeWirone left review comments

@tony-trantony-trantony-tran left review comments

@liweiyi88liweiyi88liweiyi88 left review comments

@noniagriconomienoniagriconomienoniagriconomie left review comments

@darielopperdarielopperdarielopper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

14 participants

@fabpot@Wirone@nicolas-grekas@javiereguiluz@Taluu@lyrixx@stof@tigitz@yceruto@tony-tran@liweiyi88@noniagriconomie@darielopper@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp