Spotted while discussing the client with@Seldaek
The current behavior is transient: depending on the speed of the network/server, the exception can be thrown, or not.

This forces one do deal with 3/4/5xx when the first chunk is yielded.

[HttpClient] fix throwing HTTP exceptions when the 1st chunk is emitted

3c93764

nicolas-grekas added this to the4.3 milestone

Sep 19, 2019

carsonbot added Status: Needs Review HttpClient Bug labels

Sep 19, 2019

nicolas-grekas added a commit that referenced this pull request

Sep 20, 2019

bug#33643[HttpClient] fix throwing HTTP exceptions when the 1st chu…

1575e27

…nk is emitted (nicolas-grekas)This PR was merged into the 4.3 branch.Discussion----------[HttpClient] fix throwing HTTP exceptions when the 1st chunk is emitted| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Spotted while discussing the client with@SeldaekThe current behavior is transient: depending on the speed of the network/server, the exception can be thrown, or not.This forces one do deal with 3/4/5xx when the first chunk is yielded.Commits-------3c93764 [HttpClient] fix throwing HTTP exceptions when the 1st chunk is emitted

nicolas-grekas merged commit3c93764 intosymfony:4.3

Sep 20, 2019

stof reviewed

Sep 20, 2019

View reviewed changes

src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php

		$this->assertSame(['application/json'],$response->getHeaders(false)['content-type']);
		$this->assertNotEmpty($response->getContent(false));

		$response =$client->request('GET','http://localhost:8057/404');

Copy link

Member

stofSep 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

could we create separate tests rather than a single testtestClientError actually performing multiple subsequent tests ? This would allow each test name to describe what it is testing.