Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

install from source to include components tests#33637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 2 commits intosymfony:3.4fromxabbuh:pr-33579-source-installs
Sep 19, 2019

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedSep 19, 2019
edited by nicolas-grekas
Loading

QA
Branch?3.4
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

Replaces#33634

…sts (xabbuh)"This reverts commit47fb090, reversingchanges made to6fad4f1.
@xabbuhxabbuh marked this pull request as ready for reviewSeptember 19, 2019 07:18
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's the only sensible solution to make the CI back to green.

BUT1. this adds ~3-4 minutes per deps=low/high jobs, almost doubling their time while they're already a blocker on (not so) busy days and2. it makes running the tests locally quite painful: ppl will have to use--prefer-source when testing a single component - this meansa. ppl should learn about it andb. they will have to wait more time to get up and running.

I think we should revert the PR that added.gitattributes. Active contributors should not be paying with their free time for ppl that only "+1" without caring about the consequences.

Instead, I think we should discuss a way to removeTests folders from flex, opt-in.

fancyweb reacted with thumbs up emojikaznovac reacted with thumbs down emojisstok reacted with eyes emoji
@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

nicolas-grekas added a commit that referenced this pull requestSep 19, 2019
This PR was squashed before being merged into the 3.4 branch (closes#33637).Discussion----------install from source to include components tests| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |Commits-------5aa4328 Revert "bug#33618 fix tests depending on other components' tests (xabbuh)"c792908 install from source to include components tests
@nicolas-grekasnicolas-grekas merged commit5aa4328 intosymfony:3.4Sep 19, 2019
@xabbuhxabbuh deleted the pr-33579-source-installs branchSeptember 19, 2019 08:12
@nicolas-grekas
Copy link
Member

Issue1. is fixed by#33654

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp