Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
install from source to include components tests#33637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's the only sensible solution to make the CI back to green.
BUT1. this adds ~3-4 minutes per deps=low/high jobs, almost doubling their time while they're already a blocker on (not so) busy days and2. it makes running the tests locally quite painful: ppl will have to use--prefer-source when testing a single component - this meansa. ppl should learn about it andb. they will have to wait more time to get up and running.
I think we should revert the PR that added.gitattributes. Active contributors should not be paying with their free time for ppl that only "+1" without caring about the consequences.
Instead, I think we should discuss a way to removeTests folders from flex, opt-in.
nicolas-grekas commentedSep 19, 2019
Thank you@xabbuh. |
This PR was squashed before being merged into the 3.4 branch (closes#33637).Discussion----------install from source to include components tests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Commits-------5aa4328 Revert "bug#33618 fix tests depending on other components' tests (xabbuh)"c792908 install from source to include components tests
nicolas-grekas commentedSep 20, 2019
Issue1. is fixed by#33654 |
Uh oh!
There was an error while loading.Please reload this page.
Replaces#33634