Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
move abstract test classes to Test namespace#33634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedSep 18, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
nicolas-grekas commentedSep 18, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
That doesn't make sense. We added .gitattributes because ppl did not want to get the tests in the zip, yet we're still adding them back? That's going to cause a lot of troubles in the long run, because we won't be able to know ahead of time when a test should be added to Tests or Test. Process wise, we have no CI to back that up. I'm seriously in favor of reverting the PR that added those files. We could replace them by some logic in flex instead. |
Nyholm commentedSep 18, 2019
Thank you for the PR. @xabbuh could you elaboratewhy this is needed? |
fabpot commentedSep 19, 2019
Maybe adding the |
xabbuh commentedSep 19, 2019
@Nyholm In some bundles/bridges we rely on classes from the @fabpot Not sure that really helps here. We would have the exact same problem there again I guess. Another solution could be to install from source instead (see#33637). |