Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

move abstract test classes to Test namespace#33634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xabbuh wants to merge1 commit intosymfony:3.4fromxabbuh:pr-33579

Conversation

@xabbuh
Copy link
Member

QA
Branch?3.4
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

@xabbuhxabbuh added this to the3.4 milestoneSep 18, 2019
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedSep 18, 2019
edited
Loading

That doesn't make sense. We added .gitattributes because ppl did not want to get the tests in the zip, yet we're still adding them back?

That's going to cause a lot of troubles in the long run, because we won't be able to know ahead of time when a test should be added to Tests or Test. Process wise, we have no CI to back that up.

I'm seriously in favor of reverting the PR that added those files. We could replace them by some logic in flex instead.

fancyweb reacted with thumbs up emoji

@Nyholm
Copy link
Member

Thank you for the PR.

@xabbuh could you elaboratewhy this is needed?

@fabpot
Copy link
Member

Maybe adding the.gitattributes in 3.4 was not the right move. We could do it only in 4.4 instead?

@xabbuh
Copy link
MemberAuthor

@Nyholm In some bundles/bridges we rely on classes from theTests namespace of different components. Now, with the changes done in#33579 these classes are not there anymore in ourdeps=low/deps=high build jobs.

@fabpot Not sure that really helps here. We would have the exact same problem there again I guess.

Another solution could be to install from source instead (see#33637).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@nicolas-grekas@Nyholm@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp