Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] added Ability to define a priority method for tagged service#33628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromlyrixx:dic-tagged-prio-meth
Oct 2, 2019

Conversation

@lyrixx
Copy link
Member

QA
Branch?4.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#32976
LicenseMIT
Doc PR

Korbeil, lyrixx, yceruto, deguif, renanbr, mykiwi, and TomasVotruba reacted with thumbs up emoji
@lyrixx
Copy link
MemberAuthor

I added much more tests :D

@lyrixxlyrixxforce-pushed thedic-tagged-prio-meth branch 2 times, most recently fromd102fa3 to20b8761CompareSeptember 23, 2019 15:22
@lyrixxlyrixxforce-pushed thedic-tagged-prio-meth branch 2 times, most recently fromdb5f9fb to5dac5c0CompareSeptember 27, 2019 12:32
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(failure unrelated)

@lyrixx
Copy link
MemberAuthor

lyrixx commentedSep 27, 2019•
edited
Loading

No more failures 💚

@lyrixx
Copy link
MemberAuthor

@nicolas-grekas Let's merge it?

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Definitely a needed feature, thank you!

( I left a nitpicking comment :) )

@nicolas-grekas
Copy link
Member

Thank you@lyrixx.

nicolas-grekas added a commit that referenced this pull requestOct 2, 2019
…ty method for tagged service (lyrixx)This PR was merged into the 4.4 branch.Discussion----------[DependencyInjection] added Ability to define a priority method for tagged service| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |Fix#32976| License       | MIT| Doc PR        |Commits-------c1917c2 [DependencyInjection] added Ability to define a priority method for tagged service
@nicolas-grekasnicolas-grekas merged commitc1917c2 intosymfony:4.4Oct 2, 2019
@lyrixxlyrixx deleted the dic-tagged-prio-meth branchOctober 3, 2019 07:37
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

[DI] Allow class-defined priority when using _instanceof + tags

5 participants

@lyrixx@nicolas-grekas@stof@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp