Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] ensure compatibility with type resolver 0.5#33626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if ($nestedVarTypeinstanceof Nullable) { | ||
| $varTypes[] = (string)$nestedVarType->getActualType(); | ||
| $nullable =true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is it expected that this could never be false again the loop? Just asking, I am currently on a phone 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
At least that's the current behaviour. The failing example docblock here was?string|int which was expected to revealstring andint as types both being nullable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the thing is, nullable applies to the whole typehint. Either null is allowed or it is not. But it cannot be both of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@stof, that’s what I thought but wanted to be sure 👍🏻
fabpot commentedSep 18, 2019
Thank you@xabbuh. |
… (xabbuh)This PR was merged into the 3.4 branch.Discussion----------[PropertyInfo] ensure compatibility with type resolver 0.5| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |same as#33588 but for the `3.4` branchCommits-------2d708b3 ensure compatibility with type resolver 0.5
same as#33588 but for the
3.4branch