Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
fix tests depending on other components' tests#33618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedSep 17, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
c6a7a16 to224d802CompareOskarStark approved these changesSep 18, 2019
Member
fabpot commentedSep 18, 2019
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestSep 18, 2019
This PR was merged into the 3.4 branch.Discussion----------fix tests depending on other components' tests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Commits-------cd2f3a6 fix tests depending on other components' tests
nicolas-grekas added a commit that referenced this pull requestSep 19, 2019
This PR was squashed before being merged into the 3.4 branch (closes#33637).Discussion----------install from source to include components tests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Commits-------5aa4328 Revert "bug#33618 fix tests depending on other components' tests (xabbuh)"c792908 install from source to include components tests
nicolas-grekas added a commit that referenced this pull requestSep 19, 2019
* 3.4: Re-enable previously failing PHP 7.4 test cases Revert "bug#33618 fix tests depending on other components' tests (xabbuh)" install from source to include components tests
nicolas-grekas added a commit that referenced this pull requestSep 19, 2019
* 4.3: Re-enable previously failing PHP 7.4 test cases [PhpUnitBridge] fix uninitialized variable Revert "bug#33618 fix tests depending on other components' tests (xabbuh)" install from source to include components tests
nicolas-grekas added a commit that referenced this pull requestSep 19, 2019
* 4.4: Re-enable previously failing PHP 7.4 test cases [PhpUnitBridge] fix uninitialized variable [ErrorRenderer] fix Cannot use object of type ErrorException as array exception#33631 [Twig] Add missing check Revert "bug#33618 fix tests depending on other components' tests (xabbuh)" install from source to include components tests Fix undefined constant and other minor issues [Twig] Add NotificationEmail ensure compatibility with type resolver 0.5 Call AssertEquals with proper parameters [DependencyInjection] Allow binding iterable and tagged services [Twig] Fix Twig config extra keys fix tests depending on other components' tests Fix lint commands frozen on empty stdin
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull requestSep 6, 2023
* 4.3: Re-enable previously failing PHP 7.4 test cases [PhpUnitBridge] fix uninitialized variable Revert "bugsymfony#33618 fix tests depending on other components' tests (xabbuh)" install from source to include components tests
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull requestSep 6, 2023
* 4.4: Re-enable previously failing PHP 7.4 test cases [PhpUnitBridge] fix uninitialized variable [ErrorRenderer] fix Cannot use object of type ErrorException as array exceptionsymfony#33631 [Twig] Add missing check Revert "bugsymfony#33618 fix tests depending on other components' tests (xabbuh)" install from source to include components tests Fix undefined constant and other minor issues [Twig] Add NotificationEmail ensure compatibility with type resolver 0.5 Call AssertEquals with proper parameters [DependencyInjection] Allow binding iterable and tagged services [Twig] Fix Twig config extra keys fix tests depending on other components' tests Fix lint commands frozen on empty stdin
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.