Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Draft][WebProfiler] Removed intercept_redirects config option#33607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Draft][WebProfiler] Removed intercept_redirects config option#33607
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e7c7f59 tofddbc09Compare| private$cspHandler; | ||
| publicfunction__construct(Environment$twig,bool$interceptRedirects =false,int$mode =self::ENABLED,UrlGeneratorInterface$urlGenerator =null,string$excludedAjaxPaths ='^/bundles|^/_wdt',ContentSecurityPolicyHandler$cspHandler =null) | ||
| publicfunction__construct(Environment$twig,int$mode =self::ENABLED,UrlGeneratorInterface$urlGenerator =null,string$excludedAjaxPaths ='^/bundles|^/_wdt',ContentSecurityPolicyHandler$cspHandler =null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should we have a BC layer for this signature change ? This class is not marked as@internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should mark it as@internal in 4.4 IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This class is marked as final, it should be enough ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@maxhelias no. BC breaks in argument position is related to using the class, not to extending it.
fddbc09 to32ceea6Comparefabpot commentedSep 18, 2019
People are apparently using this feature; so we are going to revert it. Sorry for the time you spent on this. |
As a follow up of#33507, where
intercept_redirectsconfig option was deprecated, removing it in master.