Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] rename SmtpEnvelope to Envelope#33562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
xabbuh commentedSep 12, 2019
/cc@fbourigault |
OskarStark approved these changesSep 12, 2019
Uh oh!
There was an error while loading.Please reload this page.
Drop the Smtp prefix so that arbitrary transports do not have to dependon SMTP specific concepts.
fabpot approved these changesSep 12, 2019
Member
fabpot commentedSep 12, 2019
@xabbuh You forgot some renamings (see tests) |
MemberAuthor
xabbuh commentedSep 13, 2019
@fabpot This seems to be related to how the mailer bridges tests are executed. The classes are actually updated. |
Member
fabpot commentedSep 13, 2019
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestSep 13, 2019
This PR was merged into the 4.4 branch.Discussion----------[Mailer] rename SmtpEnvelope to Envelope| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Drop the Smtp prefix so that arbitrary transports do not have to dependon SMTP specific concepts.Commits-------5e2c6da rename SmtpEnvelope to Envelope
chapa added a commit to chapa/symfony that referenced this pull requestNov 21, 2019
* Class `SmtpEnvelope` has been renamed to `Envelope` insymfony#33562* A required `$transport` argument has been added to `MessageEvent` insymfony#32927
chapa added a commit to chapa/symfony that referenced this pull requestNov 21, 2019
Class `DelayedSmtpEnvelope` has been renamed to `DelayedEnvelope` insymfony#33562
fabpot added a commit that referenced this pull requestNov 22, 2019
…vent (chapa)This PR was squashed before being merged into the 5.1-dev branch (closes#34475).Discussion----------[Mailer] Add UPGRADE entries about Envelope and MessageEvent* Class `SmtpEnvelope` has been renamed to `Envelope` in#33562* A required `$transport` argument has been added to `MessageEvent` in#32927| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | N/A| License | MIT| Doc PR | already up-to-dateCommits-------7baa295 [Mailer] Add UPGRADE entries about Envelope and MessageEvent
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the Smtp prefix so that arbitrary transports do not have to depend
on SMTP specific concepts.