NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Create doctrine messenger transport table on send#33559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

jrjohnson wants to merge2 commits intosymfony:4.3fromjrjohnson:setup-on-send

Closed

Create doctrine messenger transport table on send#33559

jrjohnson wants to merge2 commits intosymfony:4.3fromjrjohnson:setup-on-send

Conversation

Copy link

Contributor

jrjohnson commentedSep 12, 2019

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT
Doc PR	aligns with existing docs

Create doctrine messenger transport table on send just like it is created on get to match the
documentation and expectations for auto_setup.

Existing documentation athttps://symfony.com/doc/current/messenger.html#doctrine-transport includes:

auto_setup	Whether the table should be created automatically during send / get.	true

I think this is correct as I'd expect the table to be autocreated on set before get.

Tests are added here, but they don't actually fail correctly and I'm not sure why. I wonder if sqlite or doctrine is auto creating this table on insert when it isn't present. Maybe it's something else that you will see that I'm missing.

Create doctrine messenger transport table on send

9554525

Create this table on send just like it is created on get to match thedocumentation and expectations for auto_setup.

carsonbot added Status: Needs Review Bug labels

Sep 12, 2019

Tobion approved these changes

Sep 12, 2019

View reviewed changes

Copy link

Contributor

Tobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you delete the wrong comment in

symfony/src/Symfony/Component/Messenger/Tests/Transport/Doctrine/DoctrineIntegrationTest.php

Line 43 in9554525

// call send to auto-setup the table

please?

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Sep 12, 2019

Remove misleading comment

cfc7a60

auto-setup happens on get and send

Copy link

ContributorAuthor

jrjohnson commentedSep 12, 2019

@Tobion, yes. Deleted!

Copy link

Contributor

bendavies commentedSep 12, 2019

superseded in#32308 really (which i've not managed to finish off)

Copy link

ContributorAuthor

jrjohnson commentedSep 12, 2019•
edited
Loading

Oh good@bendavies I was considering that as a next step, I'm glad you're already looking into it. Seems like this should still be merged as a bug fix for release to be enhanced when you finish up that PR?