Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fixed incompatibility between ServiceSubscriberTrait and classes with protected $container property#33521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
a-menshchikov commentedSep 9, 2019
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #33355 |
| License | MIT |
| Doc PR |
| { | ||
| /** @var ContainerInterface */ | ||
| private$container; | ||
| private$serviceContainer; |
nicolas-grekasSep 10, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hum, looking at the code again, the property is the only way to access the container. Which means this change would break anyone using it 100% guaranteed.
That's no-go from BC perspective.
Making the property protected might be the way to go.
… protected $container property
fabpot commentedSep 11, 2019
Thank you@a-menshchikov. |
…lasses with protected $container property (a-menshchikov)This PR was squashed before being merged into the 4.3 branch (closes#33521).Discussion----------Fixed incompatibility between ServiceSubscriberTrait and classes with protected $container property| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#33355| License | MIT| Doc PR |Commits-------954dad4 Fixed incompatibility between ServiceSubscriberTrait and classes with protected $container property